[webkit-changes] [WebKit/WebKit] 093d44: WPT webcodecs/video-encoder.https.any.html is flaky
youennf
noreply at github.com
Fri Sep 8 09:06:19 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 093d44d793d28147c87ed8e321777b3223ec8b57
https://github.com/WebKit/WebKit/commit/093d44d793d28147c87ed8e321777b3223ec8b57
Author: Youenn Fablet <youennf at gmail.com>
Date: 2023-09-08 (Fri, 08 Sep 2023)
Changed paths:
M Source/WebCore/Modules/webcodecs/WebCodecsVideoEncoder.cpp
Log Message:
-----------
WPT webcodecs/video-encoder.https.any.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=261271
rdar://115108292
Reviewed by Philippe Normand.
The call to resolve the flush promise is happening within postTask, while the dequeue event is fired as part of the event loop.
The postTask might starve the event loop, thus having the flush promise resolves sooner than the dequeue events.
Also resolving a promise should be done within an event task to improve ordering of promise resolutions.
We change postTask to always go through the event loop, like now done for decoder.
Given postTask is now ensuring that the callback is executed if the encoder is alive, we remove the weakThis checks in each callback.
* Source/WebCore/Modules/webcodecs/WebCodecsVideoEncoder.cpp:
(WebCore::WebCodecsVideoEncoder::configure):
Canonical link: https://commits.webkit.org/267796@main
More information about the webkit-changes
mailing list