[webkit-changes] [WebKit/WebKit] 196776: [WPE] `TestUIClient` `/webkit/WebKitWebView/geoloc...

Vitaly Dyachkov noreply at github.com
Fri Sep 8 08:23:07 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 19677609fbb1b6db24518a1159b7cf18372ed711
      https://github.com/WebKit/WebKit/commit/19677609fbb1b6db24518a1159b7cf18372ed711
  Author: Vitaly Dyachkov <vitaly at igalia.com>
  Date:   2023-09-08 (Fri, 08 Sep 2023)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp
    M Tools/TestWebKitAPI/glib/TestExpectations.json

  Log Message:
  -----------
  [WPE] `TestUIClient` `/webkit/WebKitWebView/geolocation-permission-requests` API test times out
https://bugs.webkit.org/show_bug.cgi?id=261199

Reviewed by Carlos Garcia Campos.

267736 at main didn't help. The test still times out on WPE Release bot.

I realized that for this test to finish we don't actually need to get
the current position.

The last check in this test only verifies that for an allowed permission
request the error code returned in the error handler is not
`PERMISSION_DENIED`.

So we can pass the timeout option to
`navigator.geolocation.getCurrentPosition()`. Getting the current
position will probably time out but the test should pass.

* Tools/TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
(testWebViewGeolocationPermissionRequests):
* Tools/TestWebKitAPI/glib/TestExpectations.json:

Canonical link: https://commits.webkit.org/267793@main




More information about the webkit-changes mailing list