[webkit-changes] [WebKit/WebKit] 0ca3d9: REGRESSION(267658 at main): Crash in CSSValue::cssTex...

Tim Nguyen noreply at github.com
Fri Sep 8 06:07:17 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0ca3d955d80a15db42ca63e9240a4cbf2cef64c7
      https://github.com/WebKit/WebKit/commit/0ca3d955d80a15db42ca63e9240a4cbf2cef64c7
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2023-09-08 (Fri, 08 Sep 2023)

  Changed paths:
    A LayoutTests/fast/css/getComputedStyle-font-variant-shorthand-crash-expected.txt
    A LayoutTests/fast/css/getComputedStyle-font-variant-shorthand-crash.html
    M Source/WebCore/css/ComputedStyleExtractor.cpp

  Log Message:
  -----------
  REGRESSION(267658 at main): Crash in CSSValue::cssText() when showing web inspector
https://bugs.webkit.org/show_bug.cgi?id=261322
rdar://115124068

Reviewed by Antti Koivisto.

Avoid a nullptr deref by skipping properties that are disabled (including font-variant-emoji).

* LayoutTests/fast/css/getComputedStyle-font-variant-shorthand-crash-expected.txt: Added.
* LayoutTests/fast/css/getComputedStyle-font-variant-shorthand-crash.html: Added.
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::ComputedStyleExtractor::fontVariantShorthandValue const):

Canonical link: https://commits.webkit.org/267787@main




More information about the webkit-changes mailing list