[webkit-changes] [WebKit/WebKit] 0a73c4: Remove HTMLMediaElement.webkitHasClosedCaptions/we...

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0a73c4dbb7a070ffeac5aa344cfc728cefc86a3e
      https://github.com/WebKit/WebKit/commit/0a73c4dbb7a070ffeac5aa344cfc728cefc86a3e
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-09-08 (Fri, 08 Sep 2023)

  Changed paths:
    R LayoutTests/media/media-captions-expected.txt
    R LayoutTests/media/media-captions.html
    R LayoutTests/media/track/track-in-band-legacy-api-expected.txt
    R LayoutTests/media/track/track-in-band-legacy-api.html
    R LayoutTests/media/track/track-legacyapi-with-automatic-mode-expected.txt
    R LayoutTests/media/track/track-legacyapi-with-automatic-mode.html
    M LayoutTests/platform/glib/TestExpectations
    M LayoutTests/platform/mac-wk1/TestExpectations
    M ManualTests/media-controls.html
    M Source/WebCore/html/HTMLMediaElement.cpp
    M Source/WebCore/html/HTMLMediaElement.h
    M Source/WebCore/html/HTMLMediaElement.idl
    M Source/WebCore/page/CaptionUserPreferences.cpp
    M Source/WebKitLegacy/mac/DOM/DOMHTMLMediaElement.mm

  Log Message:
  -----------
  Remove HTMLMediaElement.webkitHasClosedCaptions/webkitClosedCaptionsVisible

https://bugs.webkit.org/show_bug.cgi?id=250870
rdar://problem/104451148

Reviewed by Eric Carlson.

Inspired by: https://src.chromium.org/viewvc/blink?view=revision&revision=159317

This patch removes 'prefixed' closedCaption extensions and align with Web-Spec.

* Source/WebCore/html/HTMLMediaElement.h:
* Source/WebCore/html/HTMLMediaElement.cpp:
(HTMLMediaElement::HTMLMediaElement): Remove unused 'm_webkitLegacyClosedCaptionOverride'
(HTMLMediaElement::configureTextTrackGroup): Remove 'condition'
(HTMLMediaElement::setWebkitClosedCaptionsVisible): Removed
(HTMLMediaElement::webkitClosedCaptionsVisible): Removed
(HTMLMediaElement::webkitHasClosedCaptions): Removed
(HTMLMediaElement::captionPreferencesChanged): Removed prefixed reference
* Source/WebCore/html/HTMLMediaElement.idl: Remove 'FIXME' and legacy stuff
* Source/WebCore/page/CaptionUserPreferences.cpp:
(CaptionUserPreferences::textTrackSelectionScore): Remove use of 'legacyOverride' and uses
* Source/WebKitLegacy/mac/DOM/DOMHTMLMediaElement.mm: Make WebKit Legacy use 'un-prefixed' extensions
* ManualTests/media-controls.html: Rebaselined
* LayoutTests/media/track/track-in-band-legacy-api.html: Deleted
* LayoutTests/media/track/track-in-band-legacy-api-expected.txt: Deleted
* LayoutTests/platform/mac-wk1/TestExpectations: Remove 'deleted' Test Expectations
* LayoutTests/platform/glib/TestExpectations: Ditto
* LayoutTests/media/media-captions.html: Deleted
* LayoutTests/media/media-captions-expected.txt: Deleted
* LayoutTests/media/track/track-legacyapi-with-automatic-mode-expected.txt: Deleted
* LayoutTests/media/track/track-legacyapi-with-automatic-mode.html: Deleted

Canonical link: https://commits.webkit.org/267780@main