[webkit-changes] [WebKit/WebKit] 56fa22: Cocoa WorkQueue::dispatchWithQOS() and dispatch() ...

Kimmo Kinnunen noreply at github.com
Fri Sep 8 00:31:50 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 56fa22f9af0ff3e8bb475e9293bf8da34d88926b
      https://github.com/WebKit/WebKit/commit/56fa22f9af0ff3e8bb475e9293bf8da34d88926b
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2023-09-08 (Fri, 08 Sep 2023)

  Changed paths:
    M Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp
    M Tools/TestWebKitAPI/Tests/WTF/WorkQueue.cpp

  Log Message:
  -----------
  Cocoa WorkQueue::dispatchWithQOS() and dispatch() work item lifetime semantics do not match
https://bugs.webkit.org/show_bug.cgi?id=260852
rdar://114618174

Reviewed by Jean-Yves Avenard and Chris Dumez.

dispatch() users expect the work function to be destructed in the
queue

Add the same semantic to dispatchWithQOS() to avoid confusion in the
code and to have uniform interface.

* Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp:
(WTF::WorkQueueBase::dispatchWithQOS):
* Tools/TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/267776@main




More information about the webkit-changes mailing list