[webkit-changes] [WebKit/WebKit] c57c92: [Xcode] Add timestamp outputs for verifier script ...

[Elliott Williams]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c57c92851648a35916fc322f535fe3192000044a
      https://github.com/WebKit/WebKit/commit/c57c92851648a35916fc322f535fe3192000044a
  Author: Elliott Williams <emw at apple.com>
  Date:   2023-09-07 (Thu, 07 Sep 2023)

  Changed paths:
    M Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj
    M Tools/Scripts/check-for-inappropriate-macros-in-external-headers
    M Tools/Scripts/check-for-webkit-framework-include-consistency

  Log Message:
  -----------
  [Xcode] Add timestamp outputs for verifier script phases
https://bugs.webkit.org/show_bug.cgi?id=261229
rdar://115076525

Reviewed by Alexey Proskuryakov.

This prevents them from re-running on every build, and from causing
module verification to re-run on every build.

Additionally, fix up some input dependencies to these scripts. "Check
For Framework Include Consistency" and "Check For Inappropriate Macros
in External Headers" should only re-run when headers change, so have
them depend on the all-product-headers.yaml VFS file generated by Xcode.

Where possible, move "Check For Inappropriate Files In Framework" phases
to run *outside* of its framework target. This script looks for
arbitrary files in the framework bundle, including those not tracked by
the build system. As a result, it's not possible to express input
dependencies, and continuing to run it as part of the framework build
causes the module verifier to re-run needlessly (XCBuild conservatively
assumes that any script phase without outputs declared may be modifying
framework headers).

* Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj:
* Tools/Scripts/check-for-inappropriate-macros-in-external-headers:
* Tools/Scripts/check-for-webkit-framework-include-consistency:

Canonical link: https://commits.webkit.org/267740@main