[webkit-changes] [WebKit/WebKit] 9cc46b: [GTK] `TestWebViewEditor` `/webkit/WebKitWebView/e...

[Vitaly Dyachkov]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9cc46b09b21f4b584ef5b4ea9d89519df6968462
      https://github.com/WebKit/WebKit/commit/9cc46b09b21f4b584ef5b4ea9d89519df6968462
  Author: Vitaly Dyachkov <vitaly at igalia.com>
  Date:   2023-09-06 (Wed, 06 Sep 2023)

  Changed paths:
    M Source/WebKit/UIProcess/API/glib/WebKitEditorState.cpp
    M Tools/TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp
    M Tools/TestWebKitAPI/glib/TestExpectations.json

  Log Message:
  -----------
  [GTK] `TestWebViewEditor` `/webkit/WebKitWebView/editable/editable` is flaky
https://bugs.webkit.org/show_bug.cgi?id=261028

Reviewed by Carlos Garcia Campos.

It seems like waiting for the `WebKitWebView`'s `draw` signal doesn't
guarantee that `WebKitEditorState` will be updated after setting
`WebKitWebView` as editable. This leads to flakiness.

The better way to make sure `WebKitEditorState` has been updated is to
wait until the cut action becomes available. To achieve this, this patch
introduces a new `WebKitEditorState`'s `changed` signal.

The test uses this new signal to ensure that `WebKitWebView` is indeed
editable before attempting to cut the selection.

* Source/WebKit/UIProcess/API/glib/WebKitEditorState.cpp:
(webkit_editor_state_class_init):
(webkitEditorStateChanged):
* Tools/TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
(loadContentsAndTryToCutSelection):
* Tools/TestWebKitAPI/glib/TestExpectations.json:

Canonical link: https://commits.webkit.org/267671@main