[webkit-changes] [WebKit/WebKit] 5d4cdb: [visionOS] System chrome autohides while resizing ...

[Aditya Keerthi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5d4cdbee487c4fdd0a88d1425f36595dc692a923
      https://github.com/WebKit/WebKit/commit/5d4cdbee487c4fdd0a88d1425f36595dc692a923
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2023-09-05 (Tue, 05 Sep 2023)

  Changed paths:
    M Source/WebKit/Configurations/WebKit.xcconfig
    M Source/WebKit/Platform/spi/ios/UIKitSPI.h
    M Source/WebKit/Platform/spi/visionos/MRUIKitSPI.h
    M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm

  Log Message:
  -----------
  [visionOS] System chrome autohides while resizing or repositioning fullscreen video
https://bugs.webkit.org/show_bug.cgi?id=261176
rdar://114793136

Reviewed by Tim Horton.

266191 at main made system chrome autohide alongside WebKit's controls in fullscreen.
However, autohide is currently not prevented while the user is interacting with
system chrome, resulting in a poor experience.

To fix, listen for notifications that indicate system chrome is being used. If
it is, reset the autohide timer.

* Source/WebKit/Configurations/WebKit.xcconfig:

Link MRUIKit, as the scene positioning notification comes from there.

* Source/WebKit/Platform/spi/ios/UIKitSPI.h:
* Source/WebKit/Platform/spi/visionos/MRUIKitSPI.h:
* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm:

Drive-by: Drop 'm_' from an Objective-C instance variable.

(-[WKFullScreenViewController initWithWebView:]):
(-[WKFullScreenViewController hideUI]):
(-[WKFullScreenViewController videoControlsManagerDidChange]):
(-[WKFullScreenViewController hideCustomControls:]):
(-[WKFullScreenViewController _didBeginInteractionWithSystemChrome:]):
(-[WKFullScreenViewController _didEndInteractionWithSystemChrome:]):

Canonical link: https://commits.webkit.org/267661@main