[webkit-changes] [WebKit/WebKit] 2bd294: AX: iOS VO+Safari does not read <summary> role or ...

Joshua Hoffman noreply at github.com
Tue Sep 5 10:27:33 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2bd294b771860b5d15509839303571e70246a1d4
      https://github.com/WebKit/WebKit/commit/2bd294b771860b5d15509839303571e70246a1d4
  Author: hoffmanjoshua <jhoffman23 at apple.com>
  Date:   2023-09-05 (Tue, 05 Sep 2023)

  Changed paths:
    A LayoutTests/accessibility/ios-simulator/aria-details-toggle-summary-expected.txt
    A LayoutTests/accessibility/ios-simulator/aria-details-toggle-summary.html
    M Source/WebCore/accessibility/AccessibilityObject.cpp
    M Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp
    M Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h
    M Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl
    M Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm

  Log Message:
  -----------
  AX: iOS VO+Safari does not read <summary> role or state
https://bugs.webkit.org/show_bug.cgi?id=257162
rdar://109684906

Reviewed by Chris Fleizach.

This patch fixes the calculation for AccessibilityObject::supportsExpanded() so that <summary> elements
describe their state when using iOS voiceover. For <details> elements, we cannot rely on checking the
aria-expanded attribute since that does not exist on details elements (the attribute 'open' is used instead).
This affects <summary> elements as they use their <detail> parents to calculate accessibilitySupportsARIAExpanded().

iOS AX tests were also added to confirm that this is the case.

* Source/WebCore/accessibility/AccessibilityObject.cpp:
Update AccessibilityObject::supportsExpanded().

* Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
* Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
* Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
* Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
Expose method for testing.

* LayoutTests/accessibility/ios-simulator/aria-details-toggle-summary-expected.txt:
* LayoutTests/accessibility/ios-simulator/aria-details-toggle-summary.html:
New test for checking isExpanded, supportsExpanded.

Canonical link: https://commits.webkit.org/267635@main




More information about the webkit-changes mailing list