[webkit-changes] [WebKit/WebKit] 753b05: Remove defaultStatus and defaultstatus

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 753b053ea7e21bc6baa244e53b7f277c3b8b1394
      https://github.com/WebKit/WebKit/commit/753b053ea7e21bc6baa244e53b7f277c3b8b1394
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2023-09-05 (Tue, 05 Sep 2023)

  Changed paths:
    M LayoutTests/fast/dom/Window/get-set-properties-expected.txt
    M LayoutTests/fast/dom/Window/get-set-properties.html
    M LayoutTests/fast/dom/Window/resources/window-properties.js
    M LayoutTests/fast/dom/Window/window-lookup-precedence-expected.txt
    M LayoutTests/fast/dom/assign-to-window-status-expected.txt
    M LayoutTests/fast/dom/resources/wrapper-identity-base.js
    M LayoutTests/fast/dom/wrapper-identity-expected.txt
    M LayoutTests/http/tests/security/cross-frame-access-put-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/defaultstatus-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/defaultstatus.html
    M LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/w3c-import.log
    M LayoutTests/js/dom/global-function-resolve-expected.txt
    M LayoutTests/js/dom/script-tests/global-function-resolve.js
    M LayoutTests/platform/gtk/fast/dom/Window/window-lookup-precedence-expected.txt
    M LayoutTests/platform/mac-wk2/fast/dom/Window/window-lookup-precedence-expected.txt
    M LayoutTests/platform/mac/fast/dom/objc-wrapper-identity-expected.txt
    M Source/WebCore/bindings/scripts/test/JS/JSTestConditionallyReadWrite.cpp
    M Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.cpp
    M Source/WebCore/loader/FrameLoader.cpp
    M Source/WebCore/page/LocalDOMWindow.cpp
    M Source/WebCore/page/LocalDOMWindow.h
    M Source/WebCore/page/LocalDOMWindow.idl
    M Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDOMWindow.cpp

  Log Message:
  -----------
  Remove defaultStatus and defaultstatus
https://bugs.webkit.org/show_bug.cgi?id=261116
rdar://114937585

Reviewed by Chris Dumez.

As far as I can tell we do not expose the status set by the website
anywhere nor do we have any desire for that.

Therefore remove window.defaultStatus and window.defaultstatus and make
window.status simply reflect itself as required by the HTML standard.

As defaultStatus and defaultstatus are on the global and can be
overridden it should be fine compatibility-wise and might even lead to
a tiny performance improvement on legacy pages that try to set these.
They are already gone in Chromium and Gecko too.

An interesting follow-up would be investigating how much of
setStatusbarText and setStatusText can be removed.

* LayoutTests/fast/dom/Window/get-set-properties-expected.txt:
* LayoutTests/fast/dom/Window/get-set-properties.html:
* LayoutTests/fast/dom/Window/resources/window-properties.js:
* LayoutTests/fast/dom/Window/window-lookup-precedence-expected.txt:
* LayoutTests/fast/dom/assign-to-window-status-expected.txt:
* LayoutTests/fast/dom/resources/wrapper-identity-base.js:
* LayoutTests/fast/dom/wrapper-identity-expected.txt:
* LayoutTests/http/tests/security/cross-frame-access-put-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/defaultstatus-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/defaultstatus.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/w3c-import.log:
* LayoutTests/js/dom/global-function-resolve-expected.txt:
* LayoutTests/js/dom/script-tests/global-function-resolve.js:
* LayoutTests/platform/gtk/fast/dom/Window/window-lookup-precedence-expected.txt:
* LayoutTests/platform/mac-wk2/fast/dom/Window/window-lookup-precedence-expected.txt:
* LayoutTests/platform/mac/fast/dom/objc-wrapper-identity-expected.txt:
* Source/WebCore/bindings/scripts/test/JS/JSTestConditionallyReadWrite.cpp:
(WebCore::JSTestConditionallyReadWriteDOMConstructor::prototypeForStructure):
* Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.cpp:
* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::didOpenURL):
(WebCore::FrameLoader::willRestoreFromCachedPage):
* Source/WebCore/page/LocalDOMWindow.cpp:
(WebCore::LocalDOMWindow::setStatus):
(WebCore::LocalDOMWindow::setDefaultStatus): Deleted.
* Source/WebCore/page/LocalDOMWindow.h:
(WebCore::LocalDOMWindow::defaultStatus const): Deleted.
* Source/WebCore/page/LocalDOMWindow.idl:
* Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDOMWindow.cpp:
(webkit_dom_dom_window_get_default_status):
(webkit_dom_dom_window_set_default_status):

Canonical link: https://commits.webkit.org/267633@main