[webkit-changes] [WebKit/WebKit] daefe5: Remove CSSValueInternalVariableValue

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: daefe5b35709bc997ea5e5624f815834e1d13740
      https://github.com/WebKit/WebKit/commit/daefe5b35709bc997ea5e5624f815834e1d13740
  Author: Antti Koivisto <antti at apple.com>
  Date:   2023-09-04 (Mon, 04 Sep 2023)

  Changed paths:
    M Source/WebCore/css/CSSCustomPropertyValue.h
    M Source/WebCore/css/CSSValueKeywords.in
    M Source/WebCore/css/parser/CSSParserIdioms.cpp
    M Source/WebCore/css/parser/CSSVariableParser.cpp
    M Source/WebCore/style/StyleBuilderCustom.h

  Log Message:
  -----------
  Remove CSSValueInternalVariableValue
https://bugs.webkit.org/show_bug.cgi?id=261112
rdar://114935023

Reviewed by Alan Baradlay.

It is not used for anything meaningful.

* Source/WebCore/css/CSSCustomPropertyValue.h:

Also remove the unnecessary and confusing createUnresolved constructor function.

* Source/WebCore/css/CSSValueKeywords.in:
* Source/WebCore/css/parser/CSSParserIdioms.cpp:
(WebCore::isValueAllowedInMode):
* Source/WebCore/css/parser/CSSVariableParser.cpp:
(WebCore::classifyVariableRange):

Return a simple struct instead of relying on CSSValueInternalVariableValue/CSSValueInvalid and a separate bool.

(WebCore::CSSVariableParser::containsValidVariableReferences):
(WebCore::CSSVariableParser::parseDeclarationValue):
(WebCore::CSSVariableParser::parseInitialValueForUniversalSyntax):
* Source/WebCore/style/StyleBuilderCustom.h:
(WebCore::Style::BuilderCustom::applyInitialCustomProperty):

Canonical link: https://commits.webkit.org/267610@main