[webkit-changes] [WebKit/WebKit] 604433: Cleanup convertingToLengthHasRequiredConversionDat...

Tim Nguyen noreply at github.com
Sun Sep 3 21:09:35 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6044332a1ccc67d068dd7f7abb645d9972f36a6e
      https://github.com/WebKit/WebKit/commit/6044332a1ccc67d068dd7f7abb645d9972f36a6e
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2023-09-03 (Sun, 03 Sep 2023)

  Changed paths:
    M Source/WebCore/css/CSSPrimitiveValue.cpp
    M Source/WebCore/css/CSSPrimitiveValueMappings.h
    M Source/WebCore/css/calc/CSSCalcExpressionNode.h
    M Source/WebCore/css/calc/CSSCalcInvertNode.h
    M Source/WebCore/css/calc/CSSCalcNegateNode.h
    M Source/WebCore/css/calc/CSSCalcOperationNode.cpp
    M Source/WebCore/css/calc/CSSCalcOperationNode.h
    M Source/WebCore/css/calc/CSSCalcPrimitiveValueNode.cpp
    M Source/WebCore/css/calc/CSSCalcPrimitiveValueNode.h
    M Source/WebCore/css/calc/CSSCalcValue.cpp
    M Source/WebCore/css/calc/CSSCalcValue.h

  Log Message:
  -----------
  Cleanup convertingToLengthHasRequiredConversionData after 267590 at main
https://bugs.webkit.org/show_bug.cgi?id=261088
rdar://114906119

Reviewed by Cameron McCormack.

Now that computedStyleDependencies collects viewport units dependencies, we can clean up convertingToLengthHasRequiredConversionData and stop traversing recursively in the calc() case (since computedStyleDependencies already does so).

* Source/WebCore/css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::convertingToLengthHasRequiredConversionData const):
* Source/WebCore/css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::convertingToLengthHasRequiredConversionData const): Deleted.
* Source/WebCore/css/calc/CSSCalcExpressionNode.h:
* Source/WebCore/css/calc/CSSCalcInvertNode.h:
* Source/WebCore/css/calc/CSSCalcNegateNode.h:
* Source/WebCore/css/calc/CSSCalcOperationNode.cpp:
(WebCore::CSSCalcOperationNode::convertingToLengthHasRequiredConversionData const): Deleted.
* Source/WebCore/css/calc/CSSCalcOperationNode.h:
* Source/WebCore/css/calc/CSSCalcPrimitiveValueNode.cpp:
(WebCore::CSSCalcPrimitiveValueNode::convertingToLengthHasRequiredConversionData const): Deleted.
* Source/WebCore/css/calc/CSSCalcPrimitiveValueNode.h:
* Source/WebCore/css/calc/CSSCalcValue.cpp:
(WebCore::CSSCalcValue::convertingToLengthHasRequiredConversionData const): Deleted.
* Source/WebCore/css/calc/CSSCalcValue.h:

Canonical link: https://commits.webkit.org/267601@main




More information about the webkit-changes mailing list