[webkit-changes] [WebKit/WebKit] 499bdf: Move filter specific code from BitmapTextureGL to ...

Commit Queue noreply at github.com
Sun Sep 3 18:35:42 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 499bdf98d4a7547259c7ed0af2486f4dff20dbd6
      https://github.com/WebKit/WebKit/commit/499bdf98d4a7547259c7ed0af2486f4dff20dbd6
  Author: Akihiro Kiuchi <Akihiro.Kiuchi at sony.com>
  Date:   2023-09-03 (Sun, 03 Sep 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/texmap/BitmapTextureGL.cpp
    M Source/WebCore/platform/graphics/texmap/BitmapTextureGL.h
    M Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp
    M Source/WebCore/platform/graphics/texmap/TextureMapperGL.h
    M Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp

  Log Message:
  -----------
  Move filter specific code from BitmapTextureGL to TextureMapperGL.
https://bugs.webkit.org/show_bug.cgi?id=261022

Reviewed by Fujii Hironori.

This is a preparation refactoring for https://bugs.webkit.org/show_bug.cgi?id=231653.

To fix the issue above, we have to change the number of passes needed to
do blur filtering according to the standard deviation of the blur.
Now the number of passes for each filter is specified in
BitmapTextureGL.cpp but other parameters regarding filtering such as
shader options are specified in TextureMapperGL.cpp, which leads to the
inconsistency and low readability.

This change moves filter specific code from BitmapTextureGL.cpp
to TextureMapperGL.cpp

* Source/WebCore/platform/graphics/texmap/BitmapTextureGL.cpp:
(WebCore::BitmapTextureGL::applyFilters):
(WebCore::getPassesRequiredForFilter): Deleted.
* Source/WebCore/platform/graphics/texmap/BitmapTextureGL.h:
(WebCore::BitmapTextureGL::FilterInfo::FilterInfo):
(WebCore::BitmapTextureGL::setFilterInfo):
* Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawTexture):
(WebCore::TextureMapperGL::drawTexturePlanarYUV):
(WebCore::TextureMapperGL::drawTextureSemiPlanarYUV):
(WebCore::TextureMapperGL::drawTexturePackedYUV):
(WebCore::TextureMapperGL::drawFilterPass):
(WebCore::getPassesRequiredForFilter):
(WebCore::TextureMapperGL::applyFilter):
(WebCore::TextureMapperGL::drawFiltered): Deleted.
* Source/WebCore/platform/graphics/texmap/TextureMapperGL.h:
* Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::paintIntoSurface):

Canonical link: https://commits.webkit.org/267599@main




More information about the webkit-changes mailing list