[webkit-changes] [WebKit/WebKit] 8e072e: Align adoptedStyleSheets (ObservableArray) with th...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8e072e6f9bed9c397cddc61ed24911d5283d8844
      https://github.com/WebKit/WebKit/commit/8e072e6f9bed9c397cddc61ed24911d5283d8844
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-09-03 (Sun, 03 Sep 2023)

  Changed paths:
    A LayoutTests/cssom/observable-array-defineProperty-expected.txt
    A LayoutTests/cssom/observable-array-defineProperty.html
    A LayoutTests/cssom/observable-array-delete-expected.txt
    A LayoutTests/cssom/observable-array-delete.html
    A LayoutTests/cssom/observable-array-setter-expected.txt
    A LayoutTests/cssom/observable-array-setter.html
    M Source/WebCore/bindings/js/JSObservableArray.cpp
    M Source/WebCore/bindings/js/JSObservableArray.h
    M Source/WebCore/css/CSSStyleSheetObservableArray.cpp
    M Source/WebCore/css/CSSStyleSheetObservableArray.h

  Log Message:
  -----------
  Align adoptedStyleSheets (ObservableArray) with the Web IDL specification
https://bugs.webkit.org/show_bug.cgi?id=260716
rdar://114822538

Reviewed by Yusuke Suzuki.

Align adoptedStyleSheets (ObservableArray) with the Web IDL specification:
- The length is now settable [1][2].
- Implement [[DefineOwnProperty]] as per [3].
- Update [[Delete]] to match [4] more closely. In particular, it can only be
  used to remove the last value in the array.

[1] https://webidl.spec.whatwg.org/#es-observable-array-set
[2] https://webidl.spec.whatwg.org/#observable-array-exotic-object-set-the-indexed-value
[3] https://webidl.spec.whatwg.org/#es-observable-array-defineProperty
[4] https://webidl.spec.whatwg.org/#es-observable-array-deleteProperty

* LayoutTests/cssom/observable-array-defineProperty-expected.txt: Added.
* LayoutTests/cssom/observable-array-defineProperty.html: Added.
* LayoutTests/cssom/observable-array-delete-expected.txt: Added.
* LayoutTests/cssom/observable-array-delete.html: Added.
* LayoutTests/cssom/observable-array-setter-expected.txt: Added.
* LayoutTests/cssom/observable-array-setter.html: Added.
* Source/WebCore/bindings/js/JSObservableArray.cpp:
(JSC::JSObservableArray::getOwnPropertySlot):
(JSC::JSObservableArray::put):
* Source/WebCore/bindings/js/JSObservableArray.h:
* Source/WebCore/css/CSSStyleSheetObservableArray.cpp:
(WebCore::CSSStyleSheetObservableArray::setLength):
* Source/WebCore/css/CSSStyleSheetObservableArray.h:

Canonical link: https://commits.webkit.org/267594@main