[webkit-changes] [WebKit/WebKit] 28241a: [IFC] LineBuilder::m_lineIsConstrainedByFloat shou...

Alan Baradlay noreply at github.com
Sat Sep 2 11:09:35 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 28241a0b3ee67a2c1a89fe6de12655485a60d59d
      https://github.com/WebKit/WebKit/commit/28241a0b3ee67a2c1a89fe6de12655485a60d59d
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-09-02 (Sat, 02 Sep 2023)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h
    M Source/WebCore/layout/formattingContexts/inline/LineLayoutResult.h
    M Source/WebCore/rendering/style/RenderStyleConstants.h

  Log Message:
  -----------
  [IFC] LineBuilder::m_lineIsConstrainedByFloat should tell if line is constrained at left/right or both sides
https://bugs.webkit.org/show_bug.cgi?id=261061

Reviewed by Antti Koivisto.

This is in preparation for supporting inline direction margin-trim.
(Move all "is there a float at this vertical position" repeating code to LineBuilder::floatConstrainedRect.)

* LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-trimmed-margin-allows-right-positioned-float-overconstraining-line-box-to-fit.html:
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::placeInlineAndFloatContent):
(WebCore::Layout::LineBuilder::initialConstraintsForLine const):
(WebCore::Layout::LineBuilder::floatConstrainedRect const):
(WebCore::Layout::LineBuilder::adjustedLineRectWithCandidateInlineContent const):
(WebCore::Layout::LineBuilder::shouldTryToPlaceFloatBox const):
(WebCore::Layout::LineBuilder::tryPlacingFloatBox):
(WebCore::Layout::LineBuilder::handleInlineContent):
(WebCore::Layout::LineBuilder::floatConstraints const): Deleted.
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h:
(WebCore::Layout::LineBuilder::isLineConstrainedByFloat const):
* Source/WebCore/layout/formattingContexts/inline/LineLayoutResult.h:
* Source/WebCore/rendering/style/RenderStyleConstants.h:

Canonical link: https://commits.webkit.org/267587@main




More information about the webkit-changes mailing list