[webkit-changes] [WebKit/WebKit] 1dc257: Some code incorrectly compares Document objects us...

Chris Dumez noreply at github.com
Fri Sep 1 22:08:24 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1dc257f3194c1771300e2b81f8edce1f41cd7e62
      https://github.com/WebKit/WebKit/commit/1dc257f3194c1771300e2b81f8edce1f41cd7e62
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-09-01 (Fri, 01 Sep 2023)

  Changed paths:
    M Source/WebCore/css/parser/CSSParserContext.cpp
    M Source/WebCore/css/parser/CSSParserContext.h
    M Source/WebCore/editing/cocoa/EditorCocoa.mm
    M Source/WebCore/html/HTMLElement.cpp
    M Source/WebCore/page/csp/ContentSecurityPolicy.cpp

  Log Message:
  -----------
  Some code incorrectly compares Document objects using CSSParserContext's comparison operator
https://bugs.webkit.org/show_bug.cgi?id=261044

Reviewed by Ryosuke Niwa and Darin Adler.

Use a named operator==() in CSSParserContext to avoid so that can no longer
happen and fix code doing bad comparisons.

* Source/WebCore/css/parser/CSSParserContext.cpp:
(WebCore::operator==): Deleted.
* Source/WebCore/css/parser/CSSParserContext.h:
* Source/WebCore/editing/cocoa/EditorCocoa.mm:
(WebCore::Editor::replaceNodeFromPasteboard):
* Source/WebCore/html/HTMLElement.cpp:
(WebCore::checkPopoverValidity):
* Source/WebCore/page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::reportViolation const):

Canonical link: https://commits.webkit.org/267577@main




More information about the webkit-changes mailing list