[webkit-changes] [WebKit/WebKit] 79256d: [motion-path] Implement coord-box for ray

Nikos Mouchtaris noreply at github.com
Fri Sep 1 16:37:04 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 79256d79a14c7bf6a0cd1b8ad56b3652669c48c7
      https://github.com/WebKit/WebKit/commit/79256d79a14c7bf6a0cd1b8ad56b3652669c48c7
  Author: Nikolaos Mouchtaris <nmouchtaris at apple.com>
  Date:   2023-09-01 (Fri, 01 Sep 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/imported/w3c/web-platform-tests/css/motion/animation/offset-path-interpolation-005-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/motion/parsing/offset-path-computed-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/motion/parsing/offset-path-parsing-valid-expected.txt
    M Source/WebCore/css/CSSRayValue.cpp
    M Source/WebCore/css/CSSRayValue.h
    M Source/WebCore/css/ComputedStyleExtractor.cpp
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
    M Source/WebCore/rendering/MotionPath.cpp
    M Source/WebCore/rendering/PathOperation.cpp
    M Source/WebCore/rendering/PathOperation.h
    M Source/WebCore/style/StyleBuilderConverter.h

  Log Message:
  -----------
  [motion-path] Implement coord-box for ray
https://bugs.webkit.org/show_bug.cgi?id=260814
rdar://114577300

Reviewed by Tim Nguyen.

Parse coord-box when included with ray, and use it to determine
the correct containg block box rect.

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/css/motion/animation/offset-path-interpolation-005-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/motion/parsing/offset-path-computed-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/motion/parsing/offset-path-parsing-valid-expected.txt:
* Source/WebCore/css/CSSRayValue.cpp:
(WebCore::CSSRayValue::customCSSText const):
(WebCore::CSSRayValue::equals const):
* Source/WebCore/css/CSSRayValue.h:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::valueForPathOperation):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeBasicShapeRayOrBox):
(WebCore::CSSPropertyParserHelpers::consumePathOperation):
(WebCore::CSSPropertyParserHelpers::consumeBasicShapeOrBox): Deleted.
* Source/WebCore/rendering/MotionPath.cpp:
(WebCore::offsetFromContainer):
(WebCore::MotionPath::motionPathDataForRenderer):
(WebCore::MotionPath::computePathForBox):
* Source/WebCore/rendering/PathOperation.h:
(WebCore::PathOperation::setReferenceBox):
(WebCore::PathOperation::referenceBox const):
(WebCore::PathOperation::PathOperation):
* Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertRayPathOperation):
(WebCore::Style::BuilderConverter::convertPathOperation):

Canonical link: https://commits.webkit.org/267566@main




More information about the webkit-changes mailing list