[webkit-changes] [WebKit/WebKit] 75e372: [css-color] Clamp lab/lch/oklab/oklch components t...

Tim Nguyen noreply at github.com
Fri Sep 1 09:23:30 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 75e3721606f8008cf933ce01d3858672e7c49b3b
      https://github.com/WebKit/WebKit/commit/75e3721606f8008cf933ce01d3858672e7c49b3b
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2023-09-01 (Fri, 01 Sep 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-lab-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-relative-color-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-relative-color.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-color-mix-function-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-lab-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-relative-color-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-relative-color.html
    R LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-relative-color-expected.html
    R LayoutTests/platform/mac-monterey/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-relative-color-expected.txt
    M LayoutTests/platform/mac-monterey/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-relative-color-expected.txt
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp

  Log Message:
  -----------
  [css-color] Clamp lab/lch/oklab/oklch components to appropriate ranges
https://bugs.webkit.org/show_bug.cgi?id=261019
rdar://114808444

Reviewed by Antti Koivisto.

According to the spec:
- Lightness for lab/lch should be clamped to a max of 100% (percentage) or 100 (number)
https://drafts.csswg.org/css-color/#specifying-lab-lch
- Lightness for oklab/oklch should be clamped to a max of 100% (percentage) or 1 (number)
https://drafts.csswg.org/css-color/#specifying-oklab-oklch

Apply that maximum and also fix some relative color syntax tests that weren't expecting the clamping.

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-lab-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-relative-color-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-relative-color.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-color-mix-function-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-lab-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-relative-color-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-relative-color.html:
* LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-relative-color-expected.html: Removed.
* LayoutTests/platform/mac-monterey/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-relative-color-expected.txt: Removed.
* LayoutTests/platform/mac-monterey/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-relative-color-expected.txt:
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::parseLabParametersRaw):
(WebCore::CSSPropertyParserHelpers::parseLCHParametersRaw):

Canonical link: https://commits.webkit.org/267555@main




More information about the webkit-changes mailing list