[webkit-changes] [WebKit/WebKit] 268201: COOP header breaks back/forward behavior when clie...

Chris Dumez noreply at github.com
Fri Sep 1 09:12:35 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 268201eb1e9423b0fd8356e2071457334a48418f
      https://github.com/WebKit/WebKit/commit/268201eb1e9423b0fd8356e2071457334a48418f
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-09-01 (Fri, 01 Sep 2023)

  Changed paths:
    M Source/WebCore/loader/FrameLoader.cpp
    M Tools/TestWebKitAPI/Tests/WebKit/WKBackForwardListTests.mm

  Log Message:
  -----------
  COOP header breaks back/forward behavior when client-side redirects are involved
https://bugs.webkit.org/show_bug.cgi?id=250781
rdar://104659192

Reviewed by Brent Fulgham.

FrameLoader::loadPostRequest() was failing to set forward the LockBackForwardList
flag from the FrameLoadRequest to the NavigationAction. As a result, the UIProcess
would not be made aware and would fail to lock the back/forward list in case of
process-swap (e.g. due to the COOP HTTP header).

* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadPostRequest):
* Tools/TestWebKitAPI/Tests/WebKit/WKBackForwardListTests.mm:
(-[WKBackForwardNavigationDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
(TEST):

Canonical link: https://commits.webkit.org/267553@main




More information about the webkit-changes mailing list