[webkit-changes] [WebKit/WebKit] d20a6a: Fix layering violation in Frame::disconnectOwnerEl...

Charlie Wolfe noreply at github.com
Tue Oct 31 22:48:18 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d20a6a2130032e592e10109d6a4617f7b741e684
      https://github.com/WebKit/WebKit/commit/d20a6a2130032e592e10109d6a4617f7b741e684
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2023-10-31 (Tue, 31 Oct 2023)

  Changed paths:
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/dom/Document.h
    M Source/WebCore/page/Frame.cpp
    M Source/WebCore/page/Frame.h
    M Source/WebCore/page/LocalFrame.cpp
    M Source/WebCore/page/LocalFrame.h

  Log Message:
  -----------
  Fix layering violation in Frame::disconnectOwnerElement()
https://bugs.webkit.org/show_bug.cgi?id=263948
rdar://117721204

Reviewed by Pascoe.

Document should only be used from LocalFrame.

* Source/WebCore/dom/Document.cpp:
(WebCore::Document::frameWasDisconnectedFromOwner): Deleted.
* Source/WebCore/dom/Document.h:
* Source/WebCore/page/Frame.cpp:
(WebCore::Frame::disconnectOwnerElement):
* Source/WebCore/page/Frame.h:
(WebCore::Frame::frameWasDisconnectedFromOwner const):
* Source/WebCore/page/LocalFrame.cpp:
(WebCore::LocalFrame::frameWasDisconnectedFromOwner const):
* Source/WebCore/page/LocalFrame.h:

Canonical link: https://commits.webkit.org/270042@main




More information about the webkit-changes mailing list