[webkit-changes] [WebKit/WebKit] eb3708: [WebGPU] webgpu:api, operation, shader_module, compil...

mwyrzykowski noreply at github.com
Tue Oct 31 12:05:02 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: eb3708646ee56c088e9dd24ac306e975391f949b
      https://github.com/WebKit/WebKit/commit/eb3708646ee56c088e9dd24ac306e975391f949b
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2023-10-31 (Tue, 31 Oct 2023)

  Changed paths:
    M LayoutTests/http/tests/webgpu/webgpu/api/operation/shader_module/compilation_info-expected.txt
    M Source/WebCore/Modules/WebGPU/Implementation/WebGPUShaderModuleImpl.cpp

  Log Message:
  -----------
  [WebGPU] webgpu:api,operation,shader_module,compilation_info:* CTS test fails
https://bugs.webkit.org/show_bug.cgi?id=263949
<radar://117722467>

Reviewed by Tadeu Zagallo.

message.linePos was off by 1 from what the CTS expects.

The CTS computes the expectation manually, not sure what is correct, but add one to align with the CTS
expectation as this has no impact on functionality.

* LayoutTests/http/tests/webgpu/webgpu/api/operation/shader_module/compilation_info-expected.txt:
We have another passing test now.

* Source/WebCore/Modules/WebGPU/Implementation/WebGPUShaderModuleImpl.cpp:
(WebCore::WebGPU::ShaderModuleImpl::compilationInfo):

Canonical link: https://commits.webkit.org/270020@main




More information about the webkit-changes mailing list