[webkit-changes] [WebKit/WebKit] b09b7b: [WebGPU] ShaderModule::isValid is incorrect

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b09b7b33ec78d65f6607433c34c01a692ea9a51f
      https://github.com/WebKit/WebKit/commit/b09b7b33ec78d65f6607433c34c01a692ea9a51f
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2023-10-31 (Tue, 31 Oct 2023)

  Changed paths:
    M Source/WebGPU/WebGPU/ShaderModule.h

  Log Message:
  -----------
  [WebGPU] ShaderModule::isValid is incorrect
https://bugs.webkit.org/show_bug.cgi?id=263980
rdar://117747914

Reviewed by Mike Wyrzykowski.

In 269779 at main I changed ShaderModule so that m_checkedResult can also contain a
compilation failure, which allowed us to report better errors. However, it's no
longer correct to assume if the module is valid by verifying if the m_checkedResult
is monostate, as an error would also mean the module is invalid. Instead, it should
check for a successful compilation.

* Source/WebGPU/WebGPU/ShaderModule.h:
(WebGPU::ShaderModule::isValid const):

Canonical link: https://commits.webkit.org/270016@main