[webkit-changes] [WebKit/WebKit] 26ad5b: [WebGPU] GPUTexture.createView fails when the form...

mwyrzykowski noreply at github.com
Mon Oct 30 11:22:45 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 26ad5b379cb6fa5d776b733974fef5312de2cbd2
      https://github.com/WebKit/WebKit/commit/26ad5b379cb6fa5d776b733974fef5312de2cbd2
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2023-10-30 (Mon, 30 Oct 2023)

  Changed paths:
    M Source/WebCore/Modules/WebGPU/Implementation/WebGPUTextureImpl.cpp
    M Source/WebGPU/WebGPU/PresentationContextIOSurface.mm
    M Source/WebGPU/WebGPU/Texture.h
    M Source/WebGPU/WebGPU/Texture.mm

  Log Message:
  -----------
  [WebGPU] GPUTexture.createView fails when the format is not specified and the texture is a depth-stencil texture and aspect is depth-only
https://bugs.webkit.org/show_bug.cgi?id=263821
<radar://117615196>

Reviewed by Tadeu Zagallo.

If the texture format is not specified, we should default to undefined
and then compute the correct format later.

* Source/WebCore/Modules/WebGPU/Implementation/WebGPUTextureImpl.cpp:
(WebCore::WebGPU::TextureImpl::createView):

* Source/WebGPU/WebGPU/PresentationContextIOSurface.mm:
(WebGPU::PresentationContextIOSurface::configure):
Pass format to avoid adding an overload.

* Source/WebGPU/WebGPU/Texture.h:
* Source/WebGPU/WebGPU/Texture.mm:
(WebGPU::Texture::usage):
Need this usage to create compatible depth stencil views.

(WebGPU::Device::createTexture):
(WebGPU::resolvedPixelFormat):
Return a compatible depth or stencil format if needed, otherwise the original format.
(WebGPU::Texture::createView):

Canonical link: https://commits.webkit.org/269960@main




More information about the webkit-changes mailing list