[webkit-changes] [WebKit/WebKit] db1581: GraphicsContextGL::m_layerComposited is a redundan...

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: db1581387a571d91b0fd3420285f19c974ecae23
      https://github.com/WebKit/WebKit/commit/db1581387a571d91b0fd3420285f19c974ecae23
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2023-10-30 (Mon, 30 Oct 2023)

  Changed paths:
    M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
    M Source/WebCore/platform/graphics/GraphicsContextGL.cpp
    M Source/WebCore/platform/graphics/GraphicsContextGL.h
    M Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm
    M Source/WebCore/platform/graphics/gbm/GraphicsContextGLGBM.cpp
    M Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp
    M Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp

  Log Message:
  -----------
  GraphicsContextGL::m_layerComposited is a redundant flag
https://bugs.webkit.org/show_bug.cgi?id=263772
rdar://117582088

Reviewed by Don Olmstead.

The flag would be queried by
WebGLRenderingContextBase::clearIfComposited to understand if the
backbuffer needs to be cleared after prepareForDisplay before next draw
call. This is already taken care of by buffersToAutoClear variable which
tracks this state and is reset in same location, at prepareForDisplay.

The flag would be queried by GraphicsContextGL prepareForDisplay
implementations. This is taken care of by the caller, e.g. the caller
only schedules a prepare when draw has happened.

Work towards simplifying the default framebuffer implementation, in
order to implement premultipliedAlpha compositing.

* Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::clearIfComposited):
(WebCore::WebGLRenderingContextBase::prepareForDisplay):
* Source/WebCore/platform/graphics/GraphicsContextGL.cpp:
(WebCore::GraphicsContextGL::markContextChanged):
(WebCore::GraphicsContextGL::markLayerComposited):
(WebCore::GraphicsContextGL::layerComposited const): Deleted.
* Source/WebCore/platform/graphics/GraphicsContextGL.h:
* Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm:
(WebCore::GraphicsContextGLCocoa::prepareForDisplayWithFinishedSignal):
* Source/WebCore/platform/graphics/gbm/GraphicsContextGLGBM.cpp:
(WebCore::GraphicsContextGLGBM::prepareForDisplay):
* Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp:
(WebCore::GraphicsContextGLTextureMapperANGLE::prepareForDisplay):
* Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp:
(WebKit::RemoteGraphicsContextGLProxy::markContextChanged):

Canonical link: https://commits.webkit.org/269939@main