[webkit-changes] [WebKit/WebKit] 0a9d09: WebGLRenderingContextBase::m_layerCleared is a red...
Kimmo Kinnunen
noreply at github.com
Mon Oct 30 03:45:31 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0a9d09eaf785b2d9b6027bc9b77ed67adbfb88d5
https://github.com/WebKit/WebKit/commit/0a9d09eaf785b2d9b6027bc9b77ed67adbfb88d5
Author: Kimmo Kinnunen <kkinnunen at apple.com>
Date: 2023-10-30 (Mon, 30 Oct 2023)
Changed paths:
M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
M Source/WebCore/html/canvas/WebGLRenderingContextBase.h
Log Message:
-----------
WebGLRenderingContextBase::m_layerCleared is a redundant flag
https://bugs.webkit.org/show_bug.cgi?id=263721
rdar://problem/117533757
Reviewed by Dan Glastonbury.
The m_layerCleared was cleared when buffers to auto clear was reset to
the default.
The m_layerCleared was set when buffers to auto clear was cleared.
The idea of the flag is to control
a) no extra default framebuffer clears being done
b) default framebuffer draw buffer is not being accessed in
WebGLRenderingContextBase::paintRenderingResultsToCanvas without
the clear happening.
The flag has same state as multiple other flags. Just remove it to
simplify the code.
* Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::initializeContextState):
(WebCore::WebGLRenderingContextBase::markContextChanged):
(WebCore::WebGLRenderingContextBase::clearIfComposited):
(WebCore::WebGLRenderingContextBase::paintRenderingResultsToCanvas):
* Source/WebCore/html/canvas/WebGLRenderingContextBase.h:
Canonical link: https://commits.webkit.org/269927@main
More information about the webkit-changes
mailing list