[webkit-changes] [WebKit/WebKit] c7327f: MediaTime isn't usable in an Expected

Jean-Yves Avenard noreply at github.com
Mon Oct 30 00:11:34 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c7327fa6d918d5c5c855b34d6f6de2f178164e60
      https://github.com/WebKit/WebKit/commit/c7327fa6d918d5c5c855b34d6f6de2f178164e60
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2023-10-30 (Mon, 30 Oct 2023)

  Changed paths:
    M Source/WTF/wtf/MediaTime.cpp
    M Source/WTF/wtf/MediaTime.h
    M Tools/TestWebKitAPI/Tests/WTF/MediaTime.cpp

  Log Message:
  -----------
  MediaTime isn't usable in an Expected
https://bugs.webkit.org/show_bug.cgi?id=263857
rdar://117659224

Reviewed by Dan Glastonbury and Eric Carlson.

Expected requires the object to be trivially copyable, which isn't the case with an explicitly defined copy constructor.
So we remove the redundant code and declare is as `= default`.

* Source/WTF/wtf/MediaTime.cpp:
(WTF::MediaTime::MediaTime): Deleted.
(WTF::MediaTime::operator=): Deleted.
* Source/WTF/wtf/MediaTime.h:
* Tools/TestWebKitAPI/Tests/WTF/MediaTime.cpp:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/269918@main




More information about the webkit-changes mailing list