[webkit-changes] [WebKit/WebKit] 264d86: REGRESSION(269844 at main): [GStreamer] WebCodecs enc...
Philippe Normand
noreply at github.com
Sun Oct 29 14:39:40 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 264d86dee5244d378f73d881bce792ddb51b75e2
https://github.com/WebKit/WebKit/commit/264d86dee5244d378f73d881bce792ddb51b75e2
Author: Philippe Normand <philn at igalia.com>
Date: 2023-10-29 (Sun, 29 Oct 2023)
Changed paths:
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-config.https.any.worker-expected.txt
M Source/WebCore/platform/VideoDecoder.cpp
M Source/WebCore/platform/audio/gstreamer/AudioEncoderGStreamer.cpp
M Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.cpp
M Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.h
M Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.cpp
Log Message:
-----------
REGRESSION(269844 at main): [GStreamer] WebCodecs encoders now closing from non-main thread
https://bugs.webkit.org/show_bug.cgi?id=263846
Reviewed by Youenn Fablet.
Schedule the close/reset of encoders and decoders in the script execution context. Otherwise the
resetEncoder() might attempt to trigger rejection of pending flush promises from a non main thread,
leading to ASSERTs hit in Debug builds.
* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-config.https.any.worker-expected.txt:
* Source/WebCore/platform/audio/gstreamer/AudioEncoderGStreamer.cpp:
(WebCore::GStreamerAudioEncoder::create):
* Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.cpp:
(WebCore::GStreamerVideoEncoder::create):
Canonical link: https://commits.webkit.org/269913@main
More information about the webkit-changes
mailing list