[webkit-changes] [WebKit/WebKit] f304f7: AX: 17 AccessibilityRole variants never constructe...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f304f766b590e789e092528fcc3bd1ca52ff0cb6
      https://github.com/WebKit/WebKit/commit/f304f766b590e789e092528fcc3bd1ca52ff0cb6
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2023-10-28 (Sat, 28 Oct 2023)

  Changed paths:
    M Source/WebCore/accessibility/AXCoreObject.h
    M Source/WebCore/accessibility/AccessibilityObject.cpp
    M Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp
    M Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp
    M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm
    M Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm
    M Source/WebCore/page/InteractionRegion.cpp

  Log Message:
  -----------
  AX: 17 AccessibilityRole variants never constructed, making them effectively dead code
https://bugs.webkit.org/show_bug.cgi?id=263832
rdar://problem/117631943

Reviewed by Chris Fleizach.

This hurts compile times and also hurts performance, as the compiler must generate branches
for these roles that will never actually be taken.

* Source/WebCore/accessibility/AXCoreObject.h:
(WebCore::accessibilityRoleToString):
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::supportsExpanded const):
(WebCore::AccessibilityObject::supportsRowCountChange const):
(WebCore::AccessibilityObject::shouldFocusActiveDescendant const):
* Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp:
* Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp:
(WebCore::atspiRole):
* Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityCanFuzzyHitTest]):
(-[WebAccessibilityObjectWrapper determineIsAccessibilityElement]):
* Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm:
(WebCore::Accessibility::createPlatformRoleMap):
* Source/WebCore/page/InteractionRegion.cpp:
(WebCore::shouldAllowAccessibilityRoleAsPointerCursorReplacement):

Canonical link: https://commits.webkit.org/269898@main