[webkit-changes] [WebKit/WebKit] 57ec68: [IFC][Ruby] Cleanup logical vs. visual naming in R...

Alan Baradlay noreply at github.com
Sat Oct 28 08:09:54 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 57ec686eff5cf6d3e8240f7aeb1b86b46afc8a8b
      https://github.com/WebKit/WebKit/commit/57ec686eff5cf6d3e8240f7aeb1b86b46afc8a8b
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-10-28 (Sat, 28 Oct 2023)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp
    M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp

  Log Message:
  -----------
  [IFC][Ruby] Cleanup logical vs. visual naming in RubyFormattingContext::sizeAnnotationBox
https://bugs.webkit.org/show_bug.cgi?id=263826

Reviewed by Antti Koivisto.

Ensure visual/logical geometry variables are prefixed accordingly.

* LayoutTests/fast/ruby/select-ruby.html:
* Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp:
(WebCore::Layout::RubyFormattingContext::sizeAnnotationBox):
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::updateRenderTreePositions):

Canonical link: https://commits.webkit.org/269890@main




More information about the webkit-changes mailing list