[webkit-changes] [WebKit/WebKit] 19fa8b: [IFC][Ruby] Fix adjacent base/annotation overhang

Alan Baradlay noreply at github.com
Sat Oct 28 06:13:31 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 19fa8bf72ae7e93665e3262e88a75bf5584e0978
      https://github.com/WebKit/WebKit/commit/19fa8bf72ae7e93665e3262e88a75bf5584e0978
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-10-28 (Sat, 28 Oct 2023)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp

  Log Message:
  -----------
  [IFC][Ruby] Fix adjacent base/annotation overhang
https://bugs.webkit.org/show_bug.cgi?id=263806

Reviewed by Antti Koivisto.

Overhanging pulls content from right to left (changes visual geometry) and in case of multiple (adjacent) base/annotation pairs
we have to have up-to-date geometry all the way to be able to do overlap checking. We can either do it
by passing in the accumulated shift to overlap checking functions (rather cumbersome) or update
the geometry for all subsequent display boxes before running the overlap test (see FIXME).

* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::applyRubyOverhang):

Canonical link: https://commits.webkit.org/269887@main




More information about the webkit-changes mailing list