[webkit-changes] [WebKit/WebKit] 77b974: Add convenience option to enable/disable all Debug...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 77b974f043d5faa8e9929c7dbc4a690b2c26517c
      https://github.com/WebKit/WebKit/commit/77b974f043d5faa8e9929c7dbc4a690b2c26517c
  Author: Mark Lam <mark.lam at apple.com>
  Date:   2023-10-27 (Fri, 27 Oct 2023)

  Changed paths:
    M Source/JavaScriptCore/jit/AssemblyHelpers.cpp
    M Source/JavaScriptCore/jsc.cpp
    M Source/JavaScriptCore/runtime/Options.cpp
    M Source/JavaScriptCore/runtime/Options.h
    M Source/JavaScriptCore/runtime/OptionsList.h

  Log Message:
  -----------
  Add convenience option to enable/disable all Debug JITCode validations.
https://bugs.webkit.org/show_bug.cgi?id=263811
rdar://117609282

Reviewed by Justin Michaud.

Sometimes, we just want to have the debuggability of a Debug build without all the JITCode
validations cluttering up the generated code.  Conversely, sometimes, we want all the
available validations enabled for a Release build test run.  We should have a jsc shell
convenience option to toggle all the JITCode validation options on or off.

What changed?
1. Added a Options::useJITAsserts() to allow us to disable all jitAssertXXX code emissions.
2. Changed Options::validateDFGExceptionHandling() to not be forced on for Debug builds.
3. Added a --useJITCodeValidations=<bool value> option to the jsc shell to enable/disable
   Options::useJITAsserts() and all JITCode validation codegen options.

* Source/JavaScriptCore/jit/AssemblyHelpers.cpp:
(JSC::AssemblyHelpers::jitAssertIsInt32):
(JSC::AssemblyHelpers::jitAssertIsJSInt32):
(JSC::AssemblyHelpers::jitAssertIsJSNumber):
(JSC::AssemblyHelpers::jitAssertIsJSDouble):
(JSC::AssemblyHelpers::jitAssertIsCell):
(JSC::AssemblyHelpers::jitAssertTagsInPlace):
(JSC::AssemblyHelpers::jitAssertHasValidCallFrame):
(JSC::AssemblyHelpers::jitAssertIsNull):
(JSC::AssemblyHelpers::jitAssertArgumentCountSane):
(JSC::AssemblyHelpers::jitAssertCodeBlockOnCallFrameWithType):
(JSC::AssemblyHelpers::jitAssertCodeBlockMatchesCurrentCalleeCodeBlockOnCallFrame):
(JSC::AssemblyHelpers::jitAssertCodeBlockOnCallFrameIsOptimizingJIT):
* Source/JavaScriptCore/jsc.cpp:
(CommandLine::parseArguments):
* Source/JavaScriptCore/runtime/Options.cpp:
(JSC::Options::setAllJITCodeValidations):
(JSC::Options::notifyOptionsChanged):
* Source/JavaScriptCore/runtime/Options.h:
* Source/JavaScriptCore/runtime/OptionsList.h:

Canonical link: https://commits.webkit.org/269879@main