[webkit-changes] [WebKit/WebKit] f3216a: Add explicit to some single argument constructors

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f3216a0c25f50722c44729b09c56c5791cd9b990
      https://github.com/WebKit/WebKit/commit/f3216a0c25f50722c44729b09c56c5791cd9b990
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2023-10-27 (Fri, 27 Oct 2023)

  Changed paths:
    M Source/WebCore/Modules/model-element/HTMLModelElement.h
    M Source/WebCore/dom/Node.h
    M Source/WebCore/html/HTMLDivElement.h
    M Source/WebCore/html/HTMLFormControlElement.h
    M Source/WebCore/html/HTMLFrameElementBase.h
    M Source/WebCore/html/HTMLFrameOwnerElement.h
    M Source/WebCore/html/HTMLFrameSetElement.h
    M Source/WebCore/html/HTMLImageElement.h
    M Source/WebCore/html/HTMLLIElement.h
    M Source/WebCore/html/HTMLMediaElement.h
    M Source/WebCore/html/HTMLOptionElement.h
    M Source/WebCore/html/HTMLPlugInElement.h
    M Source/WebCore/html/HTMLProgressElement.h
    M Source/WebCore/html/shadow/DateTimeFieldElement.h
    M Source/WebCore/html/shadow/DetailsMarkerControl.h
    M Source/WebCore/html/shadow/ProgressShadowElement.h
    M Source/WebCore/html/shadow/SliderThumbElement.h
    M Source/WebCore/html/shadow/SpinButtonElement.h
    M Source/WebCore/html/shadow/TextControlInnerElements.h
    M Source/WebCore/html/shadow/YouTubeEmbedShadowElement.h
    M Source/WebCore/html/track/TextTrackCue.h
    M Source/WebCore/mathml/MathMLMathElement.h
    M Source/WebCore/mathml/MathMLPresentationElement.h
    M Source/WebCore/mathml/MathMLRowElement.h
    M Source/WebCore/mathml/MathMLTokenElement.h
    M Source/WebCore/svg/SVGPathSegImpl.h

  Log Message:
  -----------
  Add explicit to some single argument constructors
https://bugs.webkit.org/show_bug.cgi?id=263793
rdar://117597310

Reviewed by Chris Dumez.

During development of
https://bugs.webkit.org/show_bug.cgi?id=263435 I copied some incorrect
prior art:

1. Single argument constructors should use explicit.
2. "static constexpr" should be in that order.

This change addresses 2 with the exception of third party code. It only
addresses 1 for code in Source/WebCore/html/shadow.

* Source/WebCore/Modules/model-element/HTMLModelElement.h:
* Source/WebCore/dom/Node.h:
* Source/WebCore/html/HTMLDivElement.h:
* Source/WebCore/html/HTMLFormControlElement.h:
* Source/WebCore/html/HTMLFrameElementBase.h:
* Source/WebCore/html/HTMLFrameOwnerElement.h:
* Source/WebCore/html/HTMLFrameSetElement.h:
* Source/WebCore/html/HTMLImageElement.h:
* Source/WebCore/html/HTMLLIElement.h:
* Source/WebCore/html/HTMLMediaElement.h:
* Source/WebCore/html/HTMLOptionElement.h:
* Source/WebCore/html/HTMLPlugInElement.h:
* Source/WebCore/html/HTMLProgressElement.h:
* Source/WebCore/html/shadow/DateTimeFieldElement.h:
* Source/WebCore/html/shadow/DetailsMarkerControl.h:
* Source/WebCore/html/shadow/ProgressShadowElement.h:
* Source/WebCore/html/shadow/SliderThumbElement.h:
* Source/WebCore/html/shadow/SpinButtonElement.h:
* Source/WebCore/html/shadow/TextControlInnerElements.h:
* Source/WebCore/html/shadow/YouTubeEmbedShadowElement.h:
* Source/WebCore/html/track/TextTrackCue.h:
* Source/WebCore/mathml/MathMLMathElement.h:
* Source/WebCore/mathml/MathMLPresentationElement.h:
* Source/WebCore/mathml/MathMLRowElement.h:
* Source/WebCore/mathml/MathMLTokenElement.h:
* Source/WebCore/svg/SVGPathSegImpl.h:

Canonical link: https://commits.webkit.org/269865@main