[webkit-changes] [WebKit/WebKit] a55f0e: Adopt more smart pointers in DOM code

Chris Dumez noreply at github.com
Fri Oct 27 07:15:25 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a55f0e9fc70c75494c1898d6c3e87ef8baa9b0df
      https://github.com/WebKit/WebKit/commit/a55f0e9fc70c75494c1898d6c3e87ef8baa9b0df
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-10-27 (Fri, 27 Oct 2023)

  Changed paths:
    M Source/WTF/wtf/WeakHashCountedSet.h
    M Source/WebCore/dom/Element.cpp
    M Source/WebCore/dom/IdTargetObserver.cpp
    M Source/WebCore/dom/IdTargetObserver.h
    M Source/WebCore/dom/IdTargetObserverRegistry.cpp
    M Source/WebCore/dom/IdTargetObserverRegistry.h
    M Source/WebCore/dom/IdleCallbackController.cpp
    M Source/WebCore/dom/ImageOverlay.cpp
    M Source/WebCore/dom/InlineClassicScript.cpp
    M Source/WebCore/dom/InlineStyleSheetOwner.cpp
    M Source/WebCore/dom/KeyboardEvent.cpp
    M Source/WebCore/dom/LiveNodeList.h
    M Source/WebCore/dom/LiveNodeListInlines.h
    M Source/WebCore/dom/LoadableClassicScript.cpp
    M Source/WebCore/dom/LoadableClassicScript.h
    M Source/WebCore/dom/LoadableImportMap.cpp
    M Source/WebCore/dom/LoadableScript.cpp
    M Source/WebCore/dom/LoadableScript.h
    M Source/WebCore/dom/LoadableScriptClient.h
    M Source/WebCore/dom/MessageEvent.cpp
    M Source/WebCore/dom/MessagePort.cpp
    M Source/WebCore/dom/Microtasks.cpp
    M Source/WebCore/dom/MouseEvent.cpp
    M Source/WebCore/dom/MouseRelatedEvent.cpp
    M Source/WebCore/dom/MutationObserver.cpp
    M Source/WebCore/dom/MutationObserver.h
    M Source/WebCore/dom/MutationObserverRegistration.cpp
    M Source/WebCore/dom/MutationObserverRegistration.h
    M Source/WebCore/dom/NamedNodeMap.cpp
    M Source/WebCore/dom/NamedNodeMap.h
    M Source/WebCore/dom/PendingScript.cpp
    M Source/WebCore/dom/RejectedPromiseTracker.h
    M Source/WebCore/html/HTMLDataListElement.cpp

  Log Message:
  -----------
  Adopt more smart pointers in DOM code
https://bugs.webkit.org/show_bug.cgi?id=263632

Reviewed by Ryosuke Niwa.

* Source/WTF/wtf/WeakHashCountedSet.h:
(WTF::containerSize):
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::attributeChanged):
* Source/WebCore/dom/IdTargetObserver.cpp:
(WebCore::IdTargetObserver::IdTargetObserver):
(WebCore::IdTargetObserver::~IdTargetObserver):
* Source/WebCore/dom/IdTargetObserver.h:
* Source/WebCore/dom/IdTargetObserverRegistry.cpp:
(WebCore::IdTargetObserverRegistry::addObserver):
(WebCore::IdTargetObserverRegistry::removeObserver):
(WebCore::IdTargetObserverRegistry::notifyObserversInternal):
* Source/WebCore/dom/IdTargetObserverRegistry.h:
(WebCore::IdTargetObserverRegistry::notifyObservers):
(WebCore::IdTargetObserverRegistry::IdTargetObserverRegistry): Deleted.
* Source/WebCore/dom/IdleCallbackController.cpp:
(WebCore::IdleCallbackController::queueTaskToStartIdlePeriod):
(WebCore::IdleCallbackController::queueTaskToInvokeIdleCallbacks):
* Source/WebCore/dom/ImageOverlay.cpp:
(WebCore::ImageOverlay::hasOverlay):
(WebCore::ImageOverlay::imageOverlayHost):
(WebCore::ImageOverlay::characterRange):
(WebCore::ImageOverlay::isInsideOverlay):
(WebCore::ImageOverlay::isOverlayText):
(WebCore::ImageOverlay::removeOverlaySoonIfNeeded):
(WebCore::ImageOverlay::containerRect):
(WebCore::ImageOverlay::installImageOverlayStyleSheet):
(WebCore::ImageOverlay::updateSubtree):
(WebCore::ImageOverlay::updateWithTextRecognitionResult):
* Source/WebCore/dom/InlineClassicScript.cpp:
(WebCore::InlineClassicScript::create):
* Source/WebCore/dom/InlineStyleSheetOwner.cpp:
(WebCore::InlineStyleSheetOwner::removedFromDocument):
(WebCore::InlineStyleSheetOwner::clearDocumentData):
(WebCore::InlineStyleSheetOwner::clearSheet):
(WebCore::InlineStyleSheetOwner::createSheet):
(WebCore::InlineStyleSheetOwner::sheetLoaded):
(WebCore::InlineStyleSheetOwner::startLoadingDynamicSheet):
* Source/WebCore/dom/KeyboardEvent.cpp:
(WebCore::KeyboardEvent::charCode const):
* Source/WebCore/dom/LiveNodeList.h:
(WebCore::LiveNodeList::protectedDocument const):
* Source/WebCore/dom/LiveNodeListInlines.h:
(WebCore::CachedLiveNodeList<NodeListType>::willValidateIndexCache const):
* Source/WebCore/dom/LoadableClassicScript.cpp:
(WebCore::LoadableNonModuleScriptBase::~LoadableNonModuleScriptBase):
(WebCore::LoadableNonModuleScriptBase::hasError const):
(WebCore::LoadableNonModuleScriptBase::notifyFinished):
(WebCore::LoadableNonModuleScriptBase::load):
(WebCore::LoadableClassicScript::execute):
* Source/WebCore/dom/LoadableClassicScript.h:
(WebCore::LoadableNonModuleScriptBase::protectedCachedScript):
* Source/WebCore/dom/LoadableImportMap.cpp:
(WebCore::LoadableImportMap::execute):
* Source/WebCore/dom/LoadableScript.cpp:
(WebCore::LoadableScript::LoadableScript):
(WebCore::LoadableScript::addClient):
(WebCore::LoadableScript::removeClient):
(WebCore::LoadableScript::notifyClientFinished):
* Source/WebCore/dom/LoadableScript.h:
(WebCore::LoadableScript::LoadableScript): Deleted.
* Source/WebCore/dom/LoadableScriptClient.h:
* Source/WebCore/dom/MessageEvent.cpp:
(WebCore::MessageEvent::create):
* Source/WebCore/dom/MessagePort.cpp:
(WebCore::WTF_REQUIRES_LOCK):
(WebCore::MessagePort::create):
(WebCore::MessagePort::disentangle):
(WebCore::MessagePort::messageAvailable):
(WebCore::MessagePort::start):
(WebCore::MessagePort::dispatchMessages):
(WebCore::MessagePort::disentanglePorts):
(WebCore::MessagePort::entangle):
(WebCore::MessagePort::removeEventListener):
(): Deleted.
* Source/WebCore/dom/Microtasks.cpp:
(WebCore::MicrotaskQueue::performMicrotaskCheckpoint):
* Source/WebCore/dom/MouseEvent.cpp:
(WebCore::MouseEvent::initMouseEventQuirk):
(WebCore::MouseEvent::toElement const):
(WebCore::MouseEvent::fromElement const):
* Source/WebCore/dom/MouseRelatedEvent.cpp:
(WebCore::MouseRelatedEvent::init):
(WebCore::MouseRelatedEvent::initCoordinates):
(WebCore::MouseRelatedEvent::documentToAbsoluteScaleFactor const):
(WebCore::MouseRelatedEvent::computeRelativePosition):
(WebCore::MouseRelatedEvent::locationInRootViewCoordinates const):
* Source/WebCore/dom/MutationObserver.cpp:
(WebCore::MutationObserver::deliver):
(WebCore::MutationObserver::protectedCallback const):
* Source/WebCore/dom/MutationObserver.h:
* Source/WebCore/dom/MutationObserverRegistration.cpp:
(WebCore::MutationObserverRegistration::MutationObserverRegistration):
(WebCore::MutationObserverRegistration::~MutationObserverRegistration):
(WebCore::MutationObserverRegistration::observedSubtreeNodeWillDetach):
(WebCore::MutationObserverRegistration::shouldReceiveMutationFrom const):
(WebCore::MutationObserverRegistration::isReachableFromOpaqueRoots const):
* Source/WebCore/dom/MutationObserverRegistration.h:
(WebCore::MutationObserverRegistration::protectedObserver):
* Source/WebCore/dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::ref):
(WebCore::NamedNodeMap::deref):
(WebCore::NamedNodeMap::getNamedItem const):
(WebCore::NamedNodeMap::isSupportedPropertyName const):
(WebCore::NamedNodeMap::getNamedItemNS const):
(WebCore::NamedNodeMap::removeNamedItem):
(WebCore::NamedNodeMap::element):
(WebCore::NamedNodeMap::protectedElement const):
(WebCore::NamedNodeMap::supportedPropertyNames const):
(WebCore::NamedNodeMap::removeNamedItemNS):
(WebCore::NamedNodeMap::setNamedItem):
(WebCore::NamedNodeMap::item const):
(WebCore::NamedNodeMap::length const):
* Source/WebCore/dom/NamedNodeMap.h:
* Source/WebCore/dom/PendingScript.cpp:
(WebCore::PendingScript::create):
* Source/WebCore/dom/RejectedPromiseTracker.h:

Canonical link: https://commits.webkit.org/269848@main




More information about the webkit-changes mailing list