[webkit-changes] [WebKit/WebKit] 5d2b2a: [WebGPU] std::optional<To> convertFloat(From value...

mwyrzykowski noreply at github.com
Thu Oct 26 20:33:37 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5d2b2aa7ae7a9a9618ac30304b8cb5ee54222b76
      https://github.com/WebKit/WebKit/commit/5d2b2aa7ae7a9a9618ac30304b8cb5ee54222b76
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2023-10-26 (Thu, 26 Oct 2023)

  Changed paths:
    M Source/WebGPU/WGSL/ConstantValue.h

  Log Message:
  -----------
  [WebGPU] std::optional<To> convertFloat(From value) does not work for negative values
https://bugs.webkit.org/show_bug.cgi?id=263747
<rdar://117553304>

Reviewed by Dan Glastonbury.

Small fallout from https://bugs.webkit.org/show_bug.cgi?id=263675, convertFloat
was not working with negative numbers, since std::numeric_limits<float>::min() returns
the smallest positive floating point number a float can represent.

* Source/WebGPU/WGSL/ConstantValue.h:
(WGSL::convertFloat):

Canonical link: https://commits.webkit.org/269835@main




More information about the webkit-changes mailing list