[webkit-changes] [WebKit/WebKit] 992aeb: Remove flaky, outdated http/tests/css/link-css-dis...

sideshowbarker noreply at github.com
Wed Oct 25 23:39:08 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 992aeb098fa216781c75297681b7cdc52f055a49
      https://github.com/WebKit/WebKit/commit/992aeb098fa216781c75297681b7cdc52f055a49
  Author: Michael[tm] Smith <mike at w3.org>
  Date:   2023-10-25 (Wed, 25 Oct 2023)

  Changed paths:
    R LayoutTests/http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error.html
    R LayoutTests/http/tests/css/link-css-disabled-value-with-slow-loading-sheet.html
    M LayoutTests/platform/glib/TestExpectations
    M LayoutTests/platform/gtk/TestExpectations
    M LayoutTests/platform/ios-wk2/TestExpectations
    M LayoutTests/platform/ios/TestExpectations
    M LayoutTests/platform/mac-monterey-wk1/TestExpectations
    M LayoutTests/platform/mac-wk1/TestExpectations
    M LayoutTests/platform/mac-wk2/TestExpectations
    M LayoutTests/platform/wincairo/TestExpectations
    M LayoutTests/platform/wpe/TestExpectations

  Log Message:
  -----------
  Remove flaky, outdated http/tests/css/link-css-disabled-* tests
https://bugs.webkit.org/show_bug.cgi?id=263679

Reviewed by Fujii Hironori.

This change removes two <link disabled> tests that are out of date with
current spec requirements, and that have been made redundant by current
WPT tests, and that are long-known to be flaky — and already flagged in
10 different TestExpectations files as flaky or ever outright wrong:

> Features that are not supported when NetworkProcess is enabled (i.e.
> they only work on Mountain Lion, and not on newer OS versions). There
> is no network load scheduling or prioritization with NetworkProcess.

As far as as testing standards conformance, those tests aren’t providing
any coverage for current requirements that isn’t already provided by the
following WPT tests:

- https://wpt.fyi/results/css/cssom/HTMLLinkElement-disabled-001.html
- https://wpt.fyi/results/css/cssom/HTMLLinkElement-disabled-002.html

And as far as regression testing otherwise, the tests removed in this
change don’t seem to be providing any useful regression coverage — and
per the commit comment at https://commits.webkit.org/157471@main, they
anyway also actually never seem to have been testing what they were
intended to test to begin with.

* LayoutTests/http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error.html: Removed.
* LayoutTests/http/tests/css/link-css-disabled-value-with-slow-loading-sheet.html: Removed.

Canonical link: https://commits.webkit.org/269803@main




More information about the webkit-changes mailing list