[webkit-changes] [WebKit/WebKit] 09ce80: Minor refactoring of assertion code

Per Arne Vollan noreply at github.com
Wed Oct 25 19:19:15 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 09ce8066c4df92cbcb1ba906ffaea4bc76c4aab8
      https://github.com/WebKit/WebKit/commit/09ce8066c4df92cbcb1ba906ffaea4bc76c4aab8
  Author: Per Arne Vollan <pvollan at apple.com>
  Date:   2023-10-25 (Wed, 25 Oct 2023)

  Changed paths:
    M Source/WebKit/Platform/spi/Cocoa/ExtensionKitSPI.h
    M Source/WebKit/UIProcess/AuxiliaryProcessProxy.h
    M Source/WebKit/UIProcess/Cocoa/AuxiliaryProcessProxyCocoa.mm
    M Source/WebKit/UIProcess/Cocoa/ProcessAssertionCocoa.mm
    M Source/WebKit/UIProcess/Downloads/DownloadProxyMap.cpp
    M Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp
    M Source/WebKit/UIProcess/GPU/GPUProcessProxy.h
    M Source/WebKit/UIProcess/Launcher/ProcessLauncher.h
    M Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
    M Source/WebKit/UIProcess/Network/NetworkProcessProxy.h
    M Source/WebKit/UIProcess/ProcessAssertion.cpp
    M Source/WebKit/UIProcess/ProcessAssertion.h
    M Source/WebKit/UIProcess/ProcessThrottler.cpp
    M Source/WebKit/UIProcess/ProcessThrottler.h
    M Source/WebKit/UIProcess/ProcessThrottlerClient.h
    M Source/WebKit/UIProcess/WebProcessProxy.cpp
    M Source/WebKit/UIProcess/WebProcessProxy.h
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  -----------
  Minor refactoring of assertion code
https://bugs.webkit.org/show_bug.cgi?id=263092
rdar://116884036

Reviewed by Brent Fulgham.

This patch makes AuxiliaryProcessProxy inherit from ProcessThrottlerClient, so that every process proxy class
does not need to do that. Additionally, a new create method is added to ProcessAssertion, which takes a
AuxiliaryProcessProxy parameter, instead of a PID. This static method is intended to be used when you want to
take an assertion on the GPU, Networking, or WebContent process from the UI process. This patch is also
preparing for adopting new assertion SPI from ExtensionKit, but this is not enabled by default, so there
should be no behavior change from this patch.

* Source/WebKit/NetworkProcess/Downloads/DownloadMap.cpp:
(WebKit::DownloadMap::add):
* Source/WebKit/Platform/spi/Cocoa/ExtensionKitSPI.h:
* Source/WebKit/UIProcess/AuxiliaryProcessProxy.h:
* Source/WebKit/UIProcess/Cocoa/AuxiliaryProcessProxyCocoa.mm:
* Source/WebKit/UIProcess/Cocoa/ProcessAssertionCocoa.mm:
(WebKit::ProcessAssertion::ProcessAssertion):
(WebKit::ProcessAssertion::~ProcessAssertion):
* Source/WebKit/UIProcess/Downloads/DownloadProxyMap.cpp:
(WebKit::DownloadProxyMap::createDownloadProxy):
* Source/WebKit/UIProcess/GPU/GPUProcessProxy.h:
* Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::setWebProcessHasUploads):
* Source/WebKit/UIProcess/Network/NetworkProcessProxy.h:
* Source/WebKit/UIProcess/ProcessAssertion.cpp:
(WebKit::ProcessAssertion::create):
* Source/WebKit/UIProcess/ProcessAssertion.h:
(WebKit::aquireAssertion):
(WebKit::ProcessAssertion::create): Deleted.
* Source/WebKit/UIProcess/ProcessThrottlerClient.h:
* Source/WebKit/UIProcess/WebProcessProxy.h:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/269791@main




More information about the webkit-changes mailing list