[webkit-changes] [WebKit/WebKit] c4121d: REGRESSION(261180 at main?): [ Sonoma ] TestWebKitAPI...

Eric Carlson noreply at github.com
Wed Oct 25 17:33:46 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c4121dd7d23a83ebdaf9592cb4e6ce0d6c6564cc
      https://github.com/WebKit/WebKit/commit/c4121dd7d23a83ebdaf9592cb4e6ce0d6c6564cc
  Author: Eric Carlson <eric.carlson at apple.com>
  Date:   2023-10-25 (Wed, 25 Oct 2023)

  Changed paths:
    M Source/WebKit/UIProcess/mac/DisplayCaptureSessionManager.h
    M Source/WebKit/UIProcess/mac/DisplayCaptureSessionManager.mm
    M Source/WebKit/UIProcess/mac/UserMediaPermissionRequestProxyMac.mm

  Log Message:
  -----------
  REGRESSION(261180 at main?): [ Sonoma ] TestWebKitAPI.GetDisplayMediaTest.SystemCanPrompt is constantly failing.
https://bugs.webkit.org/show_bug.cgi?id=263098
rdar://116893261

Reviewed by Jean-Yves Avenard.

The `systemCanPromptForTesting` setting should override the `requireUAGetDisplayMediaPrompt`
preference.

* Source/WebKit/UIProcess/mac/DisplayCaptureSessionManager.h:
(WebKit::DisplayCaptureSessionManager::overrideCanRequestDisplayCapturePermissionForTesting const):
* Source/WebKit/UIProcess/mac/DisplayCaptureSessionManager.mm:
(WebKit::DisplayCaptureSessionManager::canRequestDisplayCapturePermission):
* Source/WebKit/UIProcess/mac/UserMediaPermissionRequestProxyMac.mm:
(WebKit::UserMediaPermissionRequestProxyMac::canRequestDisplayCapturePermission):

Canonical link: https://commits.webkit.org/269789@main




More information about the webkit-changes mailing list