[webkit-changes] [WebKit/WebKit] d934da: [ iOS ] TestWebKitAPI.WebKit.QuotaDelegateReload i...

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d934da442b1d34474503e2334e2b0117a5771d5d
      https://github.com/WebKit/WebKit/commit/d934da442b1d34474503e2334e2b0117a5771d5d
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2023-10-25 (Wed, 25 Oct 2023)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm

  Log Message:
  -----------
  [ iOS ] TestWebKitAPI.WebKit.QuotaDelegateReload is a flaky failure.
https://bugs.webkit.org/show_bug.cgi?id=261987
rdar://115919262

Reviewed by Youenn Fablet.

When test page loads, WebKitTestrunner may receive two messages: "start" and "pass"/"fail". QuotaDelegateReload
currently expects WebKitTestrunner to receive "pass" immediately after QuotaDelegate grants quota request, but
WebKitTestRunner may receive "start" message (as it is sent before "pass"). To fix the issue, we could wait until
"start" message is received before making QuotaDelegate grant quota request, or we could ensure both message are
received in correct order. This patch implements the latter approach, as two messages may be sent consecutively when
QuotaDelegate is not involved in quota decision, and the result could be flaky.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm:
(-[QuotaMessageHandler userContentController:didReceiveScriptMessage:]):
(-[QuotaMessageHandler setExpectedMessage:]):
(-[QuotaMessageHandler setExpectedMessages:]):
(-[QuotaMessageHandler receivedMessage]): Deleted.

Canonical link: https://commits.webkit.org/269786@main