[webkit-changes] [WebKit/WebKit] 5501af: Versioning.

AndresGonzalezApple noreply at github.com
Wed Oct 25 13:53:20 PDT 2023


  Branch: refs/heads/safari-7615.1.21.13-branch
  Home:   https://github.com/WebKit/WebKit
  Commit: 5501af0f84b3543b5fb8b0b61306cfdb8d817cd0
      https://github.com/WebKit/WebKit/commit/5501af0f84b3543b5fb8b0b61306cfdb8d817cd0
  Author: Russell Epstein <repstein at apple.com>
  Date:   2023-02-07 (Tue, 07 Feb 2023)

  Changed paths:
    M Configurations/Version.xcconfig

  Log Message:
  -----------
  Versioning.

WebKit-7615.1.21.13.1

Canonical link: https://commits.webkit.org/259548.44@safari-7615.1.21.13-branch


  Commit: 7db0595c19d2b35c1058fed9bef8773e516ddbf4
      https://github.com/WebKit/WebKit/commit/7db0595c19d2b35c1058fed9bef8773e516ddbf4
  Author: Andres Gonzalez <andresg_22 at apple.com>
  Date:   2023-02-07 (Tue, 07 Feb 2023)

  Changed paths:
    M Source/WebCore/accessibility/AXObjectCache.cpp
    M Source/WebCore/accessibility/AXObjectCache.h

  Log Message:
  -----------
  Cherry-pick c11d33bb0bb2. rdar://problem/104956200

    AX: Object IDs should not be generated with AXTreeStore::generateNewID().
    https://bugs.webkit.org/show_bug.cgi?id=251577
    <rdar://problem/104956200>

    Reviewed by Chris Fleizach.

    In the patch for
        https://bugs.webkit.org/show_bug.cgi?id=249480
        <rdar://problem/103449294>

    I erroneously switched the generation of object IDS in the AXObjectCache to use AXTreeStore::generateNewID. This is wrong because generateNewID checks the presence of the ID against the IDs of AX trees and not against object IDs. This patch rectifies this by bringing back AXObjectCache::generateNewObjectID (new name).

    * Source/WebCore/accessibility/AXObjectCache.cpp:
    (WebCore::AXObjectCache::generateNewObjectID const):
    (WebCore::AXObjectCache::getAXID):
    * Source/WebCore/accessibility/AXObjectCache.h:
    (WebCore::AXObjectCache::objectForID const): No need to pass AXID by reference since it just wraps an unsgined.

    Canonical link: https://commits.webkit.org/259922@main

Canonical link: https://commits.webkit.org/259548.45@safari-7615.1.21.13-branch


Compare: https://github.com/WebKit/WebKit/compare/5501af0f84b3%5E...7db0595c19d2


More information about the webkit-changes mailing list