[webkit-changes] [WebKit/WebKit] 79b291: [ews-build] Reduce threshold for stopping build du...

Aakash J noreply at github.com
Wed Oct 25 13:09:59 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 79b2911c8639b5a7e3a0ad9f8413402a498c9827
      https://github.com/WebKit/WebKit/commit/79b2911c8639b5a7e3a0ad9f8413402a498c9827
  Author: Aakash Jain <aakash_jain at apple.com>
  Date:   2023-10-25 (Wed, 25 Oct 2023)

  Changed paths:
    M Tools/CISupport/ews-build/steps.py

  Log Message:
  -----------
  [ews-build] Reduce threshold for stopping build due to excessive logging in run-api-tests
https://bugs.webkit.org/show_bug.cgi?id=263603

Reviewed by Ryan Haddad.

In 269577 at main we added a feature to stop builds that exceed a predefined threshold of log lines
in run-api-tests, in order to prevent overloading the server. It did work, but the limit was quite high,
and buildbot was already under too much load and took long time to actually stop the build.
We should reduce that limit. Also, I analyzed data from actual runs and most runs for api-tests are under
10k log lines. It's rare for a api test run to exceed 100k logs, and most of the time it does indicate some issue.

* Tools/CISupport/ews-build/steps.py:
(BuildLogLineObserver.parseOutputLine):
(RunAPITests):
(RunAPITests.parseOutputLine):
(RunAPITests.handleExcessiveLogging):

Canonical link: https://commits.webkit.org/269778@main




More information about the webkit-changes mailing list