[webkit-changes] [WebKit/WebKit] 52fde6: Versioning.

Jonathan Bedard noreply at github.com
Wed Oct 25 12:57:45 PDT 2023


  Branch: refs/heads/safari-7616.2.9.11-branch
  Home:   https://github.com/WebKit/WebKit
  Commit: 52fde6cb42265eedeeb3c8a9231cbc3479bc45c8
      https://github.com/WebKit/WebKit/commit/52fde6cb42265eedeeb3c8a9231cbc3479bc45c8
  Author: Myah Cobbs <mcobbs at apple.com>
  Date:   2023-09-28 (Thu, 28 Sep 2023)

  Changed paths:
    M Configurations/Version.xcconfig

  Log Message:
  -----------
  Versioning.

WebKit-7616.2.9.11.1

Identifier: 265870.600 at safari-7616.2.9.11-branch


  Commit: cc89e01c57f4a559cf2c1e1f9cf9ca04b4084d4e
      https://github.com/WebKit/WebKit/commit/cc89e01c57f4a559cf2c1e1f9cf9ca04b4084d4e
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2023-09-28 (Thu, 28 Sep 2023)

  Changed paths:
    M Source/WebKit/NetworkProcess/cocoa/NetworkTaskCocoa.h
    M Source/WebKit/NetworkProcess/cocoa/NetworkTaskCocoa.mm

  Log Message:
  -----------
  Cherry-pick f7bf40970a7b. rdar://115081644

    Add a quirk for accounts.google.com for the third party IP cookie expiry capping heuristic
    https://bugs.webkit.org/show_bug.cgi?id=262062
    rdar://115081644

    Reviewed by John Wilander and Charlie Wolfe.

    This patch:

    1.  Adds a quirk to avoid treating requests to `accounts.google.com` as being from a third party IP
        *only under google.com*, for the purposes of applying 7-day expiry restrictions on incoming
        cookies.

    2.  Contains various cleanup around the `NetworkTaskCocoa.mm` file:

        -   Add a missing `namespace WebKit` around the implementation file, and moves the existing
            `using namespace WebCore` behind the WebKit namespace.

        -   Add missing source includes (which are currently not necessary, due to unified sources).

        -   Consistently use `#import` throughout this Cocoa-specific header and implementation file.

    * Source/WebKit/NetworkProcess/cocoa/NetworkTaskCocoa.h:
    * Source/WebKit/NetworkProcess/cocoa/NetworkTaskCocoa.mm:
    (WebKit::NetworkTaskCocoa::applyCookiePolicyForThirdPartyCloaking):

    Add the quirk; note that we only need to check the host of the requested URL here, because we only
    get to this codepath in the case where the request is already a first party subdomain of google.com.

    (computeIsAlwaysOnLoggingAllowed): Deleted.
    (NetworkTaskCocoa::NetworkTaskCocoa): Deleted.
    (shouldCapCookieExpiryForThirdPartyIPAddress): Deleted.
    (NetworkTaskCocoa::shouldApplyCookiePolicyForThirdPartyCloaking const): Deleted.
    (NetworkTaskCocoa::statelessCookieStorage): Deleted.
    (NetworkTaskCocoa::lastRemoteIPAddress): Deleted.
    (NetworkTaskCocoa::lastCNAMEDomain): Deleted.
    (NetworkTaskCocoa::needsFirstPartyCookieBlockingLatchModeQuirk const): Deleted.
    (NetworkTaskCocoa::applyCookiePolicyForThirdPartyCloaking): Deleted.
    (NetworkTaskCocoa::blockCookies): Deleted.
    (NetworkTaskCocoa::unblockCookies): Deleted.
    (NetworkTaskCocoa::updateTaskWithFirstPartyForSameSiteCookies): Deleted.
    (NetworkTaskCocoa::willPerformHTTPRedirection): Deleted.

    Canonical link: https://commits.webkit.org/268423@main

Identifier: 265870.601 at safari-7616.2.9.11-branch


  Commit: 3d81993a04546467557e8eee7f4f1ae5b2a85f5e
      https://github.com/WebKit/WebKit/commit/3d81993a04546467557e8eee7f4f1ae5b2a85f5e
  Author: Sammy Gill <sammy.gill at apple.com>
  Date:   2023-09-28 (Thu, 28 Sep 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-template-shorthand-areas-valid-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-template-shorthand-valid-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-template-shorthand-valid.html
    M Source/WebCore/css/ShorthandSerializer.cpp
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.h

  Log Message:
  -----------
  Cherry-pick 74849b01b119. rdar://115862393

    Directly check values of grid-template-rows and grid-template-columns when serializing grid-template with grid areas
    https://bugs.webkit.org/show_bug.cgi?id=260494
    rdar://114224504

    Reviewed by Tim Nguyen.

    The grid-template shorthand has two different options for its syntax:
    - [ <'grid-template-rows'> / <'grid-template-columns'> ]
    - [ <line-names>? <string> <track-size>? <line-names>? ]+ [ / <explicit-track-list> ]?

    In the latter version of the syntax, ShorthandSerializer would bail out
    early (and not serialize any values) if grid-template-areas (the <string>
    portion of the syntax) was not set by the grid-template shorthand. We
    should instead check the values of grid-template-rows and grid-template-columns
    directly to see if they can be expressed inside of this shorthand.

    For the rows portion we build up the shorthand iteratively, so we can
    just check if the value is a valid <track-size> and return an empty
    string if it is not since that would mean the value could not be
    expressed in the shorthand. A value being a valid <track-size> means that
    it must be one of: minmax(), fit-content(), length-percentage, flex,
    min-content, max-content, or auto. If it is not one of these then the
    value is not a <track-size>.

    For the columns portion we have to check the entire value of grid-template-columns
    beforehand since we will end up appending the whole value to the end
    of the shorthand. To check to see if a value is a valid <explicit-track-list>,
    we need to make sure the value contains only <line-names>s and <track-size>s
    with at least one <track-size> in the value.

    * LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-template-shorthand-areas-valid-expected.txt:
    * LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-template-shorthand-valid.html:
    * Source/WebCore/css/ShorthandSerializer.cpp:
    (WebCore::ShorthandSerializer::commonSerializationChecks):
    (WebCore::ShorthandSerializer::serializeGridTemplate const):
    * Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
    (WebCore::CSSPropertyParserHelpers::isGridBreadthIdent):
    (WebCore::CSSPropertyParserHelpers::consumeGridBreadth):
    * Source/WebCore/css/parser/CSSPropertyParserHelpers.h:

    Canonical link: https://commits.webkit.org/267155@main
Identifier: 265870.602 at safari-7616.2.9.11-branch


  Commit: 7e49d696a010482404bb851a2db34beee4032a75
      https://github.com/WebKit/WebKit/commit/7e49d696a010482404bb851a2db34beee4032a75
  Author: Myah Cobbs <mcobbs at apple.com>
  Date:   2023-09-29 (Fri, 29 Sep 2023)

  Changed paths:
    M Configurations/Version.xcconfig

  Log Message:
  -----------
  Versioning.

WebKit-7616.2.9.11.2

Identifier: 265870.603 at safari-7616.2.9.11-branch


  Commit: ba1dd0e508c03d5284535deb3a480962b04fa10b
      https://github.com/WebKit/WebKit/commit/ba1dd0e508c03d5284535deb3a480962b04fa10b
  Author: Dan Robson <dtr_bugzilla at apple.com>
  Date:   2023-10-02 (Mon, 02 Oct 2023)

  Changed paths:
    M .submitproject

  Log Message:
  -----------
  Cherry-pick 9873b33d379d. rdar://116351575

    Update .submitproject
    rdar://116351575

    Reviewed by Alexey Proskuryakov.

    Configurations/ directory is required to build.

    * .submitproject:

    Canonical link: https://commits.webkit.org/268735@main

Canonical link: https://commits.webkit.org/265870.604@safari-7616.2.9.11-branch


  Commit: 66aedf32fe2b8e674cd3cd54a9dfa9d5295bd385
      https://github.com/WebKit/WebKit/commit/66aedf32fe2b8e674cd3cd54a9dfa9d5295bd385
  Author: Dan Robson <dtr_bugzilla at apple.com>
  Date:   2023-10-02 (Mon, 02 Oct 2023)

  Changed paths:
    M Configurations/Version.xcconfig

  Log Message:
  -----------
  Versioning.

WebKit-7616.2.9.11.3

Canonical link: https://commits.webkit.org/265870.605@safari-7616.2.9.11-branch


  Commit: 817e2436c27dae69b67e048ab6b25faf621fb91e
      https://github.com/WebKit/WebKit/commit/817e2436c27dae69b67e048ab6b25faf621fb91e
  Author: Dan Robson <dtr_bugzilla at apple.com>
  Date:   2023-10-02 (Mon, 02 Oct 2023)

  Changed paths:
    M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp8/encoder/onyx_if.c

  Log Message:
  -----------
  Cherry-pick 2213bac36f8b. rdar://116372865

    Cherry-pick https://chromium.googlesource.com/webm/libvpx.git/+/51057f4ba894e13f9bba278905bacf6aaaecd992
    https://bugs.webkit.org/show_bug.cgi?id=262365
    rdar://116233358

    Reviewed by Mark Lam.

    * Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp8/encoder/onyx_if.c:
    (vp8_change_config):

    Canonical link: https://commits.webkit.org/267815.127@safari-7617-branch

Canonical link: https://commits.webkit.org/265870.606@safari-7616.2.9.11-branch


  Commit: c50d7890e30888ae6fd2a613e34af52da98d9741
      https://github.com/WebKit/WebKit/commit/c50d7890e30888ae6fd2a613e34af52da98d9741
  Author: Dan Robson <dtr_bugzilla at apple.com>
  Date:   2023-10-02 (Mon, 02 Oct 2023)

  Changed paths:
    M Configurations/Version.xcconfig

  Log Message:
  -----------
  Versioning.

WebKit-7616.2.9.11.4

Canonical link: https://commits.webkit.org/265870.607@safari-7616.2.9.11-branch


  Commit: 8b314e5652d633311ea36c406d45724966897819
      https://github.com/WebKit/WebKit/commit/8b314e5652d633311ea36c406d45724966897819
  Author: Dan Robson <dtr_bugzilla at apple.com>
  Date:   2023-10-03 (Tue, 03 Oct 2023)

  Changed paths:
    M Configurations/Version.xcconfig

  Log Message:
  -----------
  Versioning.

WebKit-7616.2.9.11.5

Canonical link: https://commits.webkit.org/265870.608@safari-7616.2.9.11-branch


  Commit: b3ed5d14fd743569936cd0afa87835e4c2919d52
      https://github.com/WebKit/WebKit/commit/b3ed5d14fd743569936cd0afa87835e4c2919d52
  Author: Dan Robson <dtr_bugzilla at apple.com>
  Date:   2023-10-03 (Tue, 03 Oct 2023)

  Changed paths:
    M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/test/resize_test.cc
    M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp9/common/vp9_alloccommon.c
    M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp9/encoder/vp9_encoder.c

  Log Message:
  -----------
  Cherry-pick 505f26eea3a5. rdar://116293231

    VP9 additional changes related to CVE-2023-5217
    rdar://116293231

    Reviewed by Jean-Yves Avenard.

    Cherry-picking patches that do hardening of VP9 encoder reconfiguration:
    - 02ab555e992c191e5c509ed87b3cc48ed915b447
    - 263682c9a29395055f3b3afe2d97be1828a6223f

    I had to update CHECK_MEM_ERROR call site since we need to pass cm currently, while they do pass cm->error upstream.

    While we do not think we are exercising this code path of reconfiguring while encoding,
    it is future proof and low risk to cherry-pick these changes.

    * Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/test/resize_test.cc:
    * Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp9/common/vp9_alloccommon.c:
    (free_seg_map):
    (vp9_free_context_buffers):
    (vp9_alloc_context_buffers):
    * Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp9/encoder/vp9_encoder.c:
    (free_copy_partition_data):
    (vp9_change_config):

    Canonical link: https://commits.webkit.org/267815.170@safari-7617-branch

Canonical link: https://commits.webkit.org/265870.609@safari-7616.2.9.11-branch


  Commit: bc523585a7fc0a3770351f9830ecf6c5444948bc
      https://github.com/WebKit/WebKit/commit/bc523585a7fc0a3770351f9830ecf6c5444948bc
  Author: Dan Robson <dtr_bugzilla at apple.com>
  Date:   2023-10-04 (Wed, 04 Oct 2023)

  Changed paths:
    M Configurations/Version.xcconfig

  Log Message:
  -----------
  Versioning.

WebKit-7616.2.9.11.6

Canonical link: https://commits.webkit.org/265870.610@safari-7616.2.9.11-branch


  Commit: 7e5485e208724e87224a1616eceb3fa1978eec92
      https://github.com/WebKit/WebKit/commit/7e5485e208724e87224a1616eceb3fa1978eec92
  Author: Dan Robson <dtr_bugzilla at apple.com>
  Date:   2023-10-04 (Wed, 04 Oct 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm

  Log Message:
  -----------
  Cherry-pick 53867c15edf3. rdar://115712997

    setSampleBufferAsDisplayImmediately should check that attachment array is not null
    https://bugs.webkit.org/show_bug.cgi?id=262556
    rdar://115712997

    Reviewed by Brent Fulgham.

    CMSampleBufferGetSampleAttachmentsArray may return a null attachment array even if createIfNecessary = true, in case of error.
    In that case, make sure setSampleBufferAsDisplayImmediately bails out early.

    * Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm:
    (WebCore::setSampleBufferAsDisplayImmediately):

    Canonical link: https://commits.webkit.org/268802@main

Canonical link: https://commits.webkit.org/265870.611@safari-7616.2.9.11-branch


Compare: https://github.com/WebKit/WebKit/compare/52fde6cb4226%5E...7e5485e20872


More information about the webkit-changes mailing list