[webkit-changes] [WebKit/WebKit] 5d9e97: [LBSE] Fix RenderSVGResourceClipper introduction r...

[Rob Buis]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5d9e979451aa984f77f416ae8f3a98b86373f081
      https://github.com/WebKit/WebKit/commit/5d9e979451aa984f77f416ae8f3a98b86373f081
  Author: Rob Buis <rbuis at igalia.com>
  Date:   2023-10-25 (Wed, 25 Oct 2023)

  Changed paths:
    M LayoutTests/platform/mac-ventura-wk2-lbse-text/TestExpectations
    M Source/WebCore/rendering/RenderLayer.cpp
    M Source/WebCore/rendering/RenderLayerInlines.h
    M Source/WebCore/rendering/svg/SVGResources.cpp

  Log Message:
  -----------
  [LBSE] Fix RenderSVGResourceClipper introduction regressions
https://bugs.webkit.org/show_bug.cgi?id=263650

Reviewed by Nikolas Zimmermann.

This patch fixes regressions introduced by r269635, I falsely relied on buildbot, but
LBSE needs some manual checking.

* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintSVGResourceLayer): remove incorrect save() call.
(WebCore::RenderLayer::paintLayerContents): test correct paint flags variable for PaintingSVGClippingMask.
(WebCore::RenderLayer::hitTestLayer): add logic to return false for  hit test of resources and hidden containers.
* Source/WebCore/rendering/RenderLayerInlines.h:
(WebCore::RenderLayer::hasNonOpacityTransparency const): logic was inverted.
* Source/WebCore/rendering/svg/SVGResources.cpp:
(WebCore::SVGResources::buildCachedResources): do not add pending resource for LBSE clippers.

Canonical link: https://commits.webkit.org/269774@main