[webkit-changes] [WebKit/WebKit] 3e6154: [webkitscmpy] Caller must provide arguments to rem...

Jonathan Bedard noreply at github.com
Wed Oct 25 09:46:52 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3e615409768a40be87251cc7f3448cdbd02abefe
      https://github.com/WebKit/WebKit/commit/3e615409768a40be87251cc7f3448cdbd02abefe
  Author: Jonathan Bedard <jbedard at apple.com>
  Date:   2023-10-25 (Wed, 25 Oct 2023)

  Changed paths:
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/bitbucket.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py

  Log Message:
  -----------
  [webkitscmpy] Caller must provide arguments to remote files_changed
https://bugs.webkit.org/show_bug.cgi?id=263653
rdar://117473288

Reviewed by Elliott Williams.

It doesn't make sense for a caller to invoke 'files_changed' on a remote repository
without specifying a git ref, raise an exception in that case.

* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/bitbucket.py:
(BitBucket.files_changed): Raise ValueError for invalid argument.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py:
(GitHub.files_changed): Ditto.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py:

Canonical link: https://commits.webkit.org/269765@main




More information about the webkit-changes mailing list