[webkit-changes] [WebKit/WebKit] 8842c1: [MSE][GStreamer] always reset appsink/parser state...

Enrique Ocaña González noreply at github.com
Wed Oct 25 08:00:47 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8842c1ea3c56ea9c3f3dd63784ec2d39c081b2c6
      https://github.com/WebKit/WebKit/commit/8842c1ea3c56ea9c3f3dd63784ec2d39c081b2c6
  Author: Enrique Ocaña González <eocanha at igalia.com>
  Date:   2023-10-25 (Wed, 25 Oct 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp

  Log Message:
  -----------
  [MSE][GStreamer] always reset appsink/parser state when recycling the track
https://bugs.webkit.org/show_bug.cgi?id=263532

Reviewed by Alicia Boya Garcia.

After applying [1], appsink can receive EOS event that was sent by
qtdemux before removing an "old" streamd. This marks the sink as
"received_eos" and makes it reject any events from subsequent
appends. Resulting in append failing with ParsingFailed error.

See: https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/1208
Original author: Eugene Mutavchi <Ievgen_Mutavchi at comcast.com>

[1] https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4535

* Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:
(WebCore::AppendPipeline::recycleTrackForPad): Unconditionally change the parser and appsink to NULL and PLAYING.

Canonical link: https://commits.webkit.org/269761@main




More information about the webkit-changes mailing list