[webkit-changes] [WebKit/WebKit] 123f48: Make setting a link at rel=stylesheet to “disabled” r...

[sideshowbarker]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 123f48fb7964cb8277f68beabb56ffbe5e87ee98
      https://github.com/WebKit/WebKit/commit/123f48fb7964cb8277f68beabb56ffbe5e87ee98
  Author: Michael[tm] Smith <mike at w3.org>
  Date:   2023-10-25 (Wed, 25 Oct 2023)

  Changed paths:
    M LayoutTests/fast/dom/HTMLLinkElement/disabled-attribute-expected.txt
    M LayoutTests/fast/dom/HTMLLinkElement/disabled-attribute.html
    M LayoutTests/http/tests/css/link-css-disabled-value-with-slow-loading-sheet-expected.txt
    M LayoutTests/http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error-expected.txt
    M LayoutTests/http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error.html
    M LayoutTests/http/tests/css/link-css-disabled-value-with-slow-loading-sheet.html
    M LayoutTests/imported/w3c/web-platform-tests/css/cssom/HTMLLinkElement-disabled-001-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/cssom/HTMLLinkElement-disabled-002-expected.txt
    M LayoutTests/platform/mac-monterey-wk1/TestExpectations
    M Source/WebCore/html/HTMLLinkElement.cpp

  Log Message:
  -----------
  Make setting a link at rel=stylesheet to “disabled” remove the stylesheet
https://bugs.webkit.org/show_bug.cgi?id=260642

Reviewed by Chris Dumez.

When the “disabled” attribute is added to a <link> element with a
rel=stylesheet, this change causes the stylesheet to be removed, per the
requirements in https://drafts.csswg.org/cssom/#remove-a-css-style-sheet
(which include setting the ownerNode to null) — making the behavior in
this case interoperable with existing behavior in Gecko and Blink.

Otherwise, without this change, the stylesheet isn’t removed — which breaks
spec conformance, and breaks interoperability with Gecko and Blink.

* LayoutTests/fast/dom/HTMLLinkElement/disabled-attribute-expected.txt:
* LayoutTests/fast/dom/HTMLLinkElement/disabled-attribute.html:
* LayoutTests/http/tests/css/link-css-disabled-value-with-slow-loading-sheet-expected.txt:
* LayoutTests/http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error-expected.txt:
* LayoutTests/http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error.html:
* LayoutTests/http/tests/css/link-css-disabled-value-with-slow-loading-sheet.html:
* LayoutTests/imported/w3c/web-platform-tests/css/cssom/HTMLLinkElement-disabled-001-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/cssom/HTMLLinkElement-disabled-002-expected.txt:
* LayoutTests/platform/mac-monterey-wk1/TestExpectations:
* Source/WebCore/html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::setDisabledState):

Canonical link: https://commits.webkit.org/269753@main