[webkit-changes] [WebKit/WebKit] a4ce5c: REGRESSION ( Sonoma?): [ Sonoma ] TestWebKitAPI.We...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a4ce5c78105f46b76c346e3eddd7c41ec44ae96e
      https://github.com/WebKit/WebKit/commit/a4ce5c78105f46b76c346e3eddd7c41ec44ae96e
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-10-24 (Tue, 24 Oct 2023)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/WebKitObjC/CustomProtocolsInvalidScheme.mm

  Log Message:
  -----------
  REGRESSION ( Sonoma?): [ Sonoma ] TestWebKitAPI.WebKit2CustomProtocolsTest.LoadInvalidScheme is a consistent timeout
https://bugs.webkit.org/show_bug.cgi?id=263576
rdar://117388019

Reviewed by Brent Fulgham.

The test tries calling [WKWebView loadRequest] with a URL that has an invalid scheme to make sure
no crash occurs and the load doesn't occur. We used to call the didFailProvisionalNavigation
navigation delegate. However, on Sonoma, we fail the navigation policy decision because the
request is invalid, which means that didFailProvisionalNavigation no longer gets called but
no crash or navigation occurs. Presumably, the behavior change is on CFNetwork side where they
no longer construct a valid NSURLRequest from this invalid URL. The new behavior is not incorrect
so I am simply updating the test to check that no crash or navigation occurs, instead of expecting
didFailProvisionalNavigation to get called.

* Tools/TestWebKitAPI/Tests/WebKitObjC/CustomProtocolsInvalidScheme.mm:
(-[LoadInvalidSchemeDelegate webView:didFinishNavigation:]):
(-[LoadInvalidSchemeDelegate webViewWebContentProcessDidTerminate:]):
(TestWebKitAPI::TEST):
(-[LoadInvalidSchemeDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.

Canonical link: https://commits.webkit.org/269749@main