[webkit-changes] [WebKit/WebKit] 20fbc2: [JSC] Remove unnecessary RELEASE_ASSERT and use me...

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 20fbc274db6edee062f05a1d9c693d3dd6386bc0
      https://github.com/WebKit/WebKit/commit/20fbc274db6edee062f05a1d9c693d3dd6386bc0
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2023-10-24 (Tue, 24 Oct 2023)

  Changed paths:
    M Source/JavaScriptCore/assembler/ARM64Assembler.h
    M Source/JavaScriptCore/assembler/LinkBuffer.cpp

  Log Message:
  -----------
  [JSC] Remove unnecessary RELEASE_ASSERT and use memset_pattern4 in recordLinkOffsets
https://bugs.webkit.org/show_bug.cgi?id=263625
rdar://117443303

Reviewed by Mark Lam and Justin Michaud.

This patch cleans up some of RELEASE_ASSERT in ARM64Assembler.

1. We are doing meaningless RELEASE_ASSERT repeatedly. We hoist the critical part and remove unnecessary ones if the first one meets the requirement.
   This meaningless assertions are actually hot in traces.
2. Use memset_pattern4 to fill out 4-byte patterns on Darwin.

* Source/JavaScriptCore/assembler/ARM64Assembler.h:
* Source/JavaScriptCore/assembler/LinkBuffer.cpp:
(JSC::recordLinkOffsets):

Canonical link: https://commits.webkit.org/269746@main