[webkit-changes] [WebKit/WebKit] 92f5e6: REGRESSION ( Sonoma?): [ Sonoma ] Two TestWebKitAP...

Chris Dumez noreply at github.com
Tue Oct 24 13:55:37 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 92f5e68fd049d22e10f2e272a15ffc007b035167
      https://github.com/WebKit/WebKit/commit/92f5e68fd049d22e10f2e272a15ffc007b035167
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-10-24 (Tue, 24 Oct 2023)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm

  Log Message:
  -----------
  REGRESSION ( Sonoma?): [ Sonoma ] Two TestWebKitAPI.WebKit.SlowBeforeUnloadPrompt tests are flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=263570
rdar://117382535

Reviewed by Wenson Hsieh.

Speculative fix for test flakiness on the bots:
1. Make sure we add the WebView to a window
2. Wait for first presentation update to make sure thing have settled
   before issuing the click.
3. Issue the click at (50, 50) instead of (5, 5) so that it is not so
   close to the edge.
4. Wait for the mouse event to be processed before trying to close the
   WKWebView.

The fix is speculative since it doesn't reproduce locally, only on this
bot.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm:
(TEST):

Canonical link: https://commits.webkit.org/269732@main




More information about the webkit-changes mailing list