[webkit-changes] [WebKit/WebKit] 9405d3: Use a CheckedRef for SQLiteTransaction::m_db

Charlie Wolfe noreply at github.com
Mon Oct 23 21:29:45 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9405d3e158f78bd8ac3f2ad1749dfea70623fb8d
      https://github.com/WebKit/WebKit/commit/9405d3e158f78bd8ac3f2ad1749dfea70623fb8d
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2023-10-23 (Mon, 23 Oct 2023)

  Changed paths:
    M Source/WebCore/Modules/indexeddb/server/SQLiteIDBCursor.cpp
    M Source/WebCore/platform/sql/SQLiteDatabase.h
    M Source/WebCore/platform/sql/SQLiteTransaction.cpp
    M Source/WebCore/platform/sql/SQLiteTransaction.h

  Log Message:
  -----------
  Use a CheckedRef for SQLiteTransaction::m_db
https://bugs.webkit.org/show_bug.cgi?id=263539
rdar://117364281

Reviewed by Sihui Liu and Chris Dumez.

Also remove `CanMakeWeakPtr<SQLiteDatabase>` since it's not used.

* Source/WebCore/Modules/indexeddb/server/SQLiteIDBCursor.cpp:
(WebCore::IDBServer::SQLiteIDBCursor::createSQLiteStatement):
(WebCore::IDBServer::SQLiteIDBCursor::resetAndRebindPreIndexStatementIfNecessary):
(WebCore::IDBServer::SQLiteIDBCursor::internalFetchNextRecord):
* Source/WebCore/platform/sql/SQLiteDatabase.h:
* Source/WebCore/platform/sql/SQLiteTransaction.cpp:
(WebCore::SQLiteTransaction::begin):
(WebCore::SQLiteTransaction::commit):
(WebCore::SQLiteTransaction::rollback):
(WebCore::SQLiteTransaction::stop):
(WebCore::SQLiteTransaction::wasRolledBackBySqlite const):
* Source/WebCore/platform/sql/SQLiteTransaction.h:
(WebCore::SQLiteTransaction::database const):

Canonical link: https://commits.webkit.org/269697@main




More information about the webkit-changes mailing list