[webkit-changes] [WebKit/WebKit] 728c25: Use more smart pointers in ProcessingInstruction &...

Chris Dumez noreply at github.com
Mon Oct 23 20:53:35 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 728c25250643e662df8f4b9cfa268f62c11bc1b6
      https://github.com/WebKit/WebKit/commit/728c25250643e662df8f4b9cfa268f62c11bc1b6
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-10-23 (Mon, 23 Oct 2023)

  Changed paths:
    M Source/WebCore/css/CSSStyleSheet.cpp
    M Source/WebCore/css/CSSStyleSheet.h
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/dom/Document.h
    M Source/WebCore/dom/ProcessingInstruction.cpp
    M Source/WebCore/dom/ProcessingInstruction.h
    M Source/WebCore/dom/PseudoElement.cpp
    M Source/WebCore/style/StyleScope.cpp
    M Source/WebCore/style/StyleScope.h

  Log Message:
  -----------
  Use more smart pointers in ProcessingInstruction & PseudoElement
https://bugs.webkit.org/show_bug.cgi?id=263537

Reviewed by Ryosuke Niwa.

* Source/WebCore/css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::protectedContents):
* Source/WebCore/css/CSSStyleSheet.h:
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::checkedStyleScope):
(WebCore::Document::checkedStyleScope const):
* Source/WebCore/dom/Document.h:
(WebCore::Document::styleScope):
(WebCore::Document::styleScope const):
* Source/WebCore/dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::~ProcessingInstruction):

(WebCore::ProcessingInstruction::checkStyleSheet):
Drop some unnecessary code that was used to check if we got disconnected
after firing the beforeload event (as you can see in https://commits.webkit.org/187003@main).
We've stopped firing the beforeload event a while back but this code wasn't
simplified.

(WebCore::ProcessingInstruction::isLoading const):
(WebCore::ProcessingInstruction::sheetLoaded):
(WebCore::ProcessingInstruction::setCSSStyleSheet):
(WebCore::ProcessingInstruction::setXSLStyleSheet):
(WebCore::ProcessingInstruction::protectedSheet const):
(WebCore::ProcessingInstruction::parseStyleSheet):
(WebCore::ProcessingInstruction::insertedIntoAncestor):
(WebCore::ProcessingInstruction::removedFromAncestor):
* Source/WebCore/dom/ProcessingInstruction.h:
* Source/WebCore/dom/PseudoElement.cpp:
(WebCore::PseudoElement::create):
(WebCore::PseudoElement::clearHostElement):
* Source/WebCore/style/StyleScope.cpp:
(WebCore::Style::Scope::incrementPtrCount const):
(WebCore::Style::Scope::decrementPtrCount const):
(WebCore::Style::Scope::createDocumentResolver):
(WebCore::Style::Scope::releaseMemory):
(WebCore::Style::Scope::didRemovePendingStylesheet):
(WebCore::Style::Scope::addStyleSheetCandidateNode):
(WebCore::Style::Scope::collectActiveStyleSheets):
(WebCore::Style::Scope::updateActiveStyleSheets):
(WebCore::Style::Scope::invalidateStyleAfterStyleSheetChange):
(WebCore::Style::Scope::activeStyleSheetsForInspector):
(WebCore::Style::Scope::flushPendingDescendantUpdates):
(WebCore::Style::Scope::scheduleUpdate):
(WebCore::Style::Scope::collectResolverScopes):
(WebCore::Style::Scope::didChangeStyleSheetEnvironment):
(WebCore::Style::Scope::didChangeViewportSize):
(WebCore::Style::Scope::invalidateMatchedDeclarationsCache):
(WebCore::Style::Scope::pendingUpdateTimerFired):
(WebCore::Style::Scope::documentScope):
(WebCore::Style::Scope::updateQueryContainerState):
* Source/WebCore/style/StyleScope.h:

Canonical link: https://commits.webkit.org/269694@main




More information about the webkit-changes mailing list